Skip to content

Fix banned user login spinner by using config admin_email - #690

Merged
GonzaloGM merged 3 commits into
masterfrom
fix/login-admin-email-messages
Sep 22, 2026
Merged

GonzaloGM merged 3 commits into
masterfrom
fix/login-admin-email-messages

Conversation

@GonzaloGM

Copy link
Copy Markdown
Contributor

Summary

  • Fixes production login error handling for banned and inactive users where $t('usuarioBanneado') threw a vue-i18n SyntaxError on @@ in hardcoded email strings, leaving the login button spinner stuck.
  • Replaces hardcoded contact emails in login i18n copy with {adminEmail} interpolation sourced from config.admin_email.
  • Adds loginContactMessages helpers and hardens the login error handler with try/finally so loading state always resets.

Test plan

  • npm run test:unit -- --run src/utils/loginContactMessages.test.js src/components/views/Login.view.test.js
  • npx playwright test e2e-frontend/login.spec.js
  • npm run lint
  • npm run build:web
  • Backend AuthControllerApiTest (no backend changes; verified still passing)
  • Manual: attempt login with a banned user in production-like build and confirm deactivated-account message shows with configured admin email

@GonzaloGM
GonzaloGM merged commit 2be9d6d into master Sep 22, 2026
2 checks passed
@GonzaloGM
GonzaloGM deleted the fix/login-admin-email-messages branch September 22, 2026 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant