Repository navigation
Fix the background snapping to a darker, saturated look when opening - #1
Merged
Merged
Conversation
The blurred wallpaper was only requested when the window opened and rendered in the background (for aerial wallpapers, by decoding a video frame). Until it arrived the system blur showed instead; then the wallpaper replaced it in a single frame, with a saturation boost on top. - Render the blurred wallpaper ahead of time: at launch, on Space and display changes, and when the wallpaper store changes - On a cold start, wait up to 0.25 s for it before fading in; if it's later, cross-fade it in instead of swapping - Use the system blur only when the wallpaper can't be read - Drop the saturation boost; Launchpad only blurred and dimmed the wallpaper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening Relaunch faded into a soft blur, then the background snapped to a darker, much more saturated look in a single frame.
Cause: the blurred wallpaper was only requested when the window opened, and rendered in the background. For animated (aerial) wallpapers that means decoding a video frame, which takes a moment. Until it arrived, the system blur of whatever was behind the window showed. Then the wallpaper replaced it with no animation, and with a 1.15× saturation boost on top.
Launchpad didn't do this. It faded in one blurred, dimmed copy of the desktop picture and never swapped backgrounds mid-animation.
Fix
Measured
Screen recordings at 60 fps, average of a background patch beside the grid: