Skip to content

chore(vscode): make buttons neater html #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfdking merged 1 commit into from
Jul 3, 2025
Merged

chore(vscode): make buttons neater html #4886

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 21 additions & 26 deletions vscode/react/src/components/graph/SettingsControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Menu } from '@headlessui/react'
import { Menu, MenuButton, MenuItem, MenuItems } from '@headlessui/react'
import { CheckIcon } from '@heroicons/react/24/outline'
import { CogIcon } from '@/components/graph/CogIcon'
import clsx from 'clsx'
Expand All @@ -17,39 +17,34 @@ export function SettingsControl({
as="div"
className="relative"
>
<Menu.Button
<MenuButton
className="react-flow__controls-button"
title="Settings"
>
<CogIcon
className="h-3 w-3"
aria-hidden="true"
/>
</Menu.Button>
<Menu.Items className="absolute bottom-0 left-full ml-2 w-56 origin-bottom-left divide-y bg-theme shadow-lg focus:outline-none z-50">
<Menu.Item>
{({ active }) => (
<button
className={clsx(
'group flex w-full items-center px-2 py-1 text-sm',
'text-[var(--vscode-button-foreground)]',
active
? 'bg-[var(--vscode-button-background)]'
: 'bg-[var(--vscode-button-hoverBackground)]',
)}
onClick={() => onWithColumnsChange(!showColumns)}
>
<span className="flex-1 text-left">Show Columns</span>
{showColumns && (
<CheckIcon
className="h-4 w-4 text-primary-500"
aria-hidden="true"
/>
)}
</button>
</MenuButton>
<MenuItems className="absolute bottom-0 left-full ml-2 w-56 origin-bottom-left divide-y bg-theme shadow-lg focus:outline-none z-50">
<MenuItem
as="button"
className={clsx(
'group flex w-full items-center px-2 py-1 text-sm',
'text-[var(--vscode-button-foreground)]',
'hover:bg-[var(--vscode-button-background)] bg-[var(--vscode-button-hoverBackground)]',
)}
</Menu.Item>
</Menu.Items>
onClick={() => onWithColumnsChange(!showColumns)}
>
<span className="flex-1 text-left">Show Columns</span>
{showColumns && (
<CheckIcon
className="h-4 w-4 text-primary-500"
aria-hidden="true"
/>
)}
</MenuItem>
</MenuItems>
</Menu>
)
}