Skip to content

fix(vscode): allow undoing clicking of lineage columns#4876

Merged
benfdking merged 1 commit intomainfrom
fix_removing_click_on_columns
Jul 2, 2025
Merged

fix(vscode): allow undoing clicking of lineage columns#4876
benfdking merged 1 commit intomainfrom
fix_removing_click_on_columns

Conversation

@benfdking
Copy link
Copy Markdown
Contributor

@benfdking benfdking commented Jul 2, 2025

  • when you click a column in the lineage it allows it to show that
    columns lineage
  • this fixes a bug where unclicking it didn't work
  • introduces Column domain type to start shoring up things

@benfdking benfdking force-pushed the fix_removing_click_on_columns branch from d0b628d to 450595a Compare July 2, 2025 13:52
@benfdking benfdking requested a review from Copilot July 2, 2025 13:52
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements toggling of lineage column selection in the VS Code React UI by mapping API columns to a domain model and enabling dynamic disable state.

  • Adds a Column domain type and a fromAPIColumn mapper
  • Updates graph context and components to consume the new domain Column
  • Refactors ModelNode to map API columns and push missing ones; refactors ModelColumns to use a dynamic disabled prop

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
vscode/react/src/domain/column.ts Introduce Column type and fromAPIColumn mapper
vscode/react/src/components/graph/context.tsx Swap API Column import for domain Column
vscode/react/src/components/graph/ModelNode.tsx Map API columns via fromAPIColumn, handle missing columns
vscode/react/src/components/graph/ModelColumns.tsx Change static disabled prop to dynamic disabled
Comments suppressed due to low confidence (2)

vscode/react/src/components/graph/ModelColumns.tsx:210

  • The disabled prop is now dynamic. Ensure there are unit or integration tests covering both enabled and disabled states of the column items to prevent regressions.
              disabled={disabled}

vscode/react/src/components/graph/ModelNode.tsx:69

  • The identifier EnumColumnType is not imported, which will cause a reference error. Please import it from the appropriate module (e.g., @/api/client).
          fromAPIColumn({ name: column, type: EnumColumnType.UNKNOWN }),

Comment thread vscode/react/src/components/graph/ModelNode.tsx Outdated
Comment thread vscode/react/src/components/graph/ModelNode.tsx
- when you click a column in the lineage it allows it to show that
  columns lineage
- this fixes a bug where unclicking it didn't work
@benfdking benfdking force-pushed the fix_removing_click_on_columns branch from 450595a to 63052cc Compare July 2, 2025 14:01
@benfdking benfdking merged commit d2d8c2f into main Jul 2, 2025
28 of 29 checks passed
@benfdking benfdking deleted the fix_removing_click_on_columns branch July 2, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants