fix(vscode): allow undoing clicking of lineage columns#4876
Merged
Conversation
d0b628d to
450595a
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Implements toggling of lineage column selection in the VS Code React UI by mapping API columns to a domain model and enabling dynamic disable state.
- Adds a
Columndomain type and afromAPIColumnmapper - Updates graph context and components to consume the new domain
Column - Refactors
ModelNodeto map API columns and push missing ones; refactorsModelColumnsto use a dynamicdisabledprop
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| vscode/react/src/domain/column.ts | Introduce Column type and fromAPIColumn mapper |
| vscode/react/src/components/graph/context.tsx | Swap API Column import for domain Column |
| vscode/react/src/components/graph/ModelNode.tsx | Map API columns via fromAPIColumn, handle missing columns |
| vscode/react/src/components/graph/ModelColumns.tsx | Change static disabled prop to dynamic disabled |
Comments suppressed due to low confidence (2)
vscode/react/src/components/graph/ModelColumns.tsx:210
- The
disabledprop is now dynamic. Ensure there are unit or integration tests covering both enabled and disabled states of the column items to prevent regressions.
disabled={disabled}
vscode/react/src/components/graph/ModelNode.tsx:69
- The identifier
EnumColumnTypeis not imported, which will cause a reference error. Please import it from the appropriate module (e.g.,@/api/client).
fromAPIColumn({ name: column, type: EnumColumnType.UNKNOWN }),
georgesittas
approved these changes
Jul 2, 2025
- when you click a column in the lineage it allows it to show that columns lineage - this fixes a bug where unclicking it didn't work
450595a to
63052cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
columns lineage