Fix: make MSSQL merge exists implementation opt-in#4870
Merged
Conversation
treysp
force-pushed
the
trey/mssql-merge-properties
branch
4 times, most recently
from
d2d2a6c to
331afd1
Compare
treysp
force-pushed
the
trey/mssql-merge-properties
branch
from
331afd1 to
229da08
Compare
izeigerman
approved these changes
Jul 2, 2025
georgesittas
approved these changes
Jul 2, 2025
treysp
force-pushed
the
trey/mssql-merge-properties
branch
from
229da08 to
0ab401a
Compare
treysp
force-pushed
the
trey/mssql-merge-properties
branch
from
0ab401a to
027fbb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently updated the MSSQL
MERGEimplementation to use theEXISTSoperator for performance improvement.The updated implementation does not always improve performance and is incompatible with some column data types (e.g.,
GEOMETRY).This PR makes the newer implementation opt-in via the
mssql_merge_existsflag in theMODELphysical_propertiessection.Original feature request: #4568