Merged
Conversation
erindru
reviewed
Jun 26, 2025
erindru
reviewed
Jun 26, 2025
erindru
reviewed
Jun 26, 2025
erindru
reviewed
Jun 26, 2025
izeigerman
reviewed
Jun 27, 2025
Collaborator
georgesittas
left a comment
georgesittas
left a comment
There was a problem hiding this comment.
Nice work, looks good. Is the next step to manually intercept the adapter instantiations elsewhere (e.g., unit tests), to ensure the IDs are properly generated in their execute as well?
Collaborator
Author
That's right, the first iteration covers only the snapshot evaluator for now. Subsequent iterations can also include the engine adapters in EDIT: Actually, intercepting the unit test queries may not be straightforward because they've ran well before the plan id has been generated. |
VaggelisD
changed the title
izeigerman
reviewed
Jun 27, 2025
izeigerman
reviewed
Jun 27, 2025
izeigerman
reviewed
Jun 30, 2025
izeigerman
approved these changes
Jun 30, 2025
georgesittas
approved these changes
Jun 30, 2025
VaggelisD
force-pushed
the
vaggelisd/track_plan
branch
from
b5424e8 to
640ef92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the
SnapshotEvaluatorsuch that it appends a comment containing theplan_idat each query generated under it.This can help associate historical queries with a plan after the fact and paves the way for tagging queries with labels/tags in engines like BigQuery and Snowflake.