Skip to content

Chore: Add metadata_updated_snapshots to EvaluatablePlan #4796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crericha merged 1 commit into from
Jun 23, 2025
Merged

Chore: Add metadata_updated_snapshots to EvaluatablePlan #4796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sqlmesh/core/plan/definition.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,6 +261,7 @@ def to_evaluatable(self) -> EvaluatablePlan:
indirectly_modified_snapshots={
s.name: sorted(snapshot_ids) for s, snapshot_ids in self.indirectly_modified.items()
},
metadata_updated_snapshots=sorted(self.metadata_updated),
removed_snapshots=sorted(self.context_diff.removed_snapshots),
requires_backfill=self.requires_backfill,
models_to_backfill=self.models_to_backfill,
Expand Down Expand Up @@ -298,6 +299,7 @@ class EvaluatablePlan(PydanticModel):
ensure_finalized_snapshots: bool
directly_modified_snapshots: t.List[SnapshotId]
indirectly_modified_snapshots: t.Dict[str, t.List[SnapshotId]]
metadata_updated_snapshots: t.List[SnapshotId]
removed_snapshots: t.List[SnapshotId]
requires_backfill: bool
models_to_backfill: t.Optional[t.Set[str]] = None
Expand Down
13 changes: 13 additions & 0 deletions tests/core/test_plan_stages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ def test_build_plan_stages_basic(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[snapshot_a.snapshot_id, snapshot_b.snapshot_id],
indirectly_modified_snapshots={},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -215,6 +216,7 @@ def test_build_plan_stages_with_before_all_and_after_all(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[snapshot_a.snapshot_id, snapshot_b.snapshot_id],
indirectly_modified_snapshots={},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -323,6 +325,7 @@ def test_build_plan_stages_select_models(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[snapshot_a.snapshot_id, snapshot_b.snapshot_id],
indirectly_modified_snapshots={},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill={snapshot_a.name},
Expand Down Expand Up @@ -422,6 +425,7 @@ def test_build_plan_stages_basic_no_backfill(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[snapshot_a.snapshot_id, snapshot_b.snapshot_id],
indirectly_modified_snapshots={},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -531,6 +535,7 @@ def test_build_plan_stages_restatement(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[], # No changes
indirectly_modified_snapshots={}, # No changes
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -642,6 +647,7 @@ def test_build_plan_stages_forward_only(
indirectly_modified_snapshots={
new_snapshot_a.name: [new_snapshot_b.snapshot_id],
},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -770,6 +776,7 @@ def test_build_plan_stages_forward_only_dev(
indirectly_modified_snapshots={
new_snapshot_a.name: [new_snapshot_b.snapshot_id],
},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -893,6 +900,7 @@ def _get_snapshots(snapshot_ids: t.List[SnapshotId]) -> t.Dict[SnapshotId, Snaps
indirectly_modified_snapshots={
new_snapshot_a.name: [new_snapshot_b.snapshot_id],
},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -1016,6 +1024,7 @@ def test_build_plan_stages_forward_only_ensure_finalized_snapshots(
indirectly_modified_snapshots={
new_snapshot_a.name: [new_snapshot_b.snapshot_id],
},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -1088,6 +1097,7 @@ def test_build_plan_stages_removed_model(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[],
indirectly_modified_snapshots={},
metadata_updated_snapshots=[],
removed_snapshots=[snapshot_b.snapshot_id],
requires_backfill=False,
models_to_backfill=None,
Expand Down Expand Up @@ -1169,6 +1179,7 @@ def test_build_plan_stages_environment_suffix_target_changed(
ensure_finalized_snapshots=False,
directly_modified_snapshots=[],
indirectly_modified_snapshots={},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=False,
models_to_backfill=None,
Expand Down Expand Up @@ -1268,6 +1279,7 @@ def test_build_plan_stages_indirect_non_breaking_no_migration(
indirectly_modified_snapshots={
new_snapshot_a.name: [new_snapshot_b.snapshot_id],
},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down Expand Up @@ -1355,6 +1367,7 @@ def test_build_plan_stages_indirect_non_breaking_view_migration(
indirectly_modified_snapshots={
new_snapshot_a.name: [new_snapshot_c.snapshot_id],
},
metadata_updated_snapshots=[],
removed_snapshots=[],
requires_backfill=True,
models_to_backfill=None,
Expand Down