fix(mssql): update SQL keywords to uppercase for consistency#4795
Merged
izeigerman merged 3 commits intoSQLMesh:mainfrom Jun 24, 2025
Merged
fix(mssql): update SQL keywords to uppercase for consistency#4795izeigerman merged 3 commits intoSQLMesh:mainfrom
izeigerman merged 3 commits intoSQLMesh:mainfrom
Conversation
eb2cac6 to
53c07ab
Compare
a26ce7f to
24bf21f
Compare
georgesittas
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates SQL queries in the MSSQL engine adapter and its corresponding tests to use uppercase identifiers for schema objects (
INFORMATION_SCHEMA,TABLES,COLUMNS, etc.) to align with SQL standards and improve consistency. The changes span both the core implementation and the test suite.Core MSSQL Engine Updates:
columnsmethod insqlmesh/core/engine_adapter/mssql.pyto use uppercase identifiers for schema objects (COLUMN_NAME,DATA_TYPE, etc.) and table-related keywords (TABLE_NAME,TABLE_SCHEMA).table_existsmethod insqlmesh/core/engine_adapter/mssql.pyto use uppercase identifiers forINFORMATION_SCHEMA.TABLESand table-related keywords (TABLE_NAME,TABLE_SCHEMA).Test Updates for MSSQL Engine:
tests/core/engine_adapter/test_mssql.pyto match the updated uppercase schema object identifiers in tests forcolumns,table_exists, and various table operations such asCREATE TABLE,MERGE, andINSERT.