fix(lsp): return context error in case it failed#4787
Merged
Conversation
benfdking
requested review from
Copilot and
themisvaltinos
and removed request for
Copilot
| context: t.Optional[Context] = None | ||
|
|
||
|
|
||
| ContextState = Union[NoContext, ContextLoaded, ContextFailed] |
Collaborator
There was a problem hiding this comment.
im wondering whether this is the best approach since now since only ContextLoaded has the lsp_context we would need to have either type guards or assertions in quite a lot of places
benfdking
force-pushed
the
improve_showing_error
branch
from
af92129 to
118b698
Compare
- adds the context state to the lsp - adds only partially working tests to extension where assertions need to be readded in the future
benfdking
force-pushed
the
improve_showing_error
branch
from
118b698 to
8932b6c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertions need to be readded in the future