Fix(mssql): Properly quote table and views when dropping in mssql#4773
Merged
themisvaltinos merged 3 commits intomainfrom Jun 20, 2025
Merged
Fix(mssql): Properly quote table and views when dropping in mssql#4773themisvaltinos merged 3 commits intomainfrom
themisvaltinos merged 3 commits intomainfrom
Conversation
themisvaltinos
force-pushed
the
themis/destroymssql
branch
from
be59517 to
215ceae
Compare
georgesittas
approved these changes
Jun 20, 2025
Co-authored-by: Jo <46752250+georgesittas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update fixes quoting in mssql's
drop_schemato correctly handle table and view names containing spaces or special characters. closes #4633While this won't be an issue in recent sqlglot versions, the change fool proofs by adding proper square bracket quoting for schema and object names. Also since
_drop_objectdoes not account for dialect when usingto_tableit is addressed indrop_schemaand it is passed as a table there.