Skip to content

fix(vscode): allow uv pip executable called through tcloud#4766

Merged
benfdking merged 1 commit intomainfrom
fixing_uv_pip
Jun 19, 2025
Merged

fix(vscode): allow uv pip executable called through tcloud#4766
benfdking merged 1 commit intomainfrom
fixing_uv_pip

Conversation

@benfdking
Copy link
Copy Markdown
Contributor

@benfdking benfdking commented Jun 19, 2025

  • sets up environment where tcloud is called so can run uv
  • manual test
  • e2e tests

@benfdking benfdking marked this pull request as ready for review June 19, 2025 15:16
@benfdking
Copy link
Copy Markdown
Contributor Author

@benfdking benfdking requested a review from Copilot June 19, 2025 15:23

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the getTcloudBin utility to return structured execution info (including env, workspace path, and args) instead of just a path, and updates all downstream execAsync calls to use the new SqlmeshExecInfo.

  • Changed getTcloudBin return type and injected Python environment variables
  • Updated all execAsync invocations to pass bin and env from the new exec info
  • Refactored SQLMesh and LSP commands to use the unified execution format

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
vscode/extension/src/utilities/sqlmesh/sqlmesh.ts Updated getTcloudBin return type, built env, and adjusted all calls to use bin and env
vscode/extension/src/auth/auth.ts Switched execAsync calls to use tcloudBin.value.bin and env
Comments suppressed due to low confidence (2)

vscode/extension/src/utilities/sqlmesh/sqlmesh.ts:56

  • [nitpick] The JSDoc comment still refers to returning a string path. Please update it to describe the new SqlmeshExecInfo (including bin, workspacePath, env, and args).
 * @returns The tcloud executable for the current Python environment.

vscode/extension/src/utilities/sqlmesh/sqlmesh.ts:72

  • [nitpick] The new error branch for getPythonEnvVariables isn’t covered by existing tests—consider adding a unit test to verify that a failure in env variable resolution returns the expected error.
  if (isErr(envVariables)) {

Comment thread vscode/extension/src/utilities/sqlmesh/sqlmesh.ts
@benfdking benfdking changed the title fix(vscode): allow uv pip executable fix(vscode): allow uv pip executable called through tcloud Jun 19, 2025
@benfdking benfdking merged commit 9a732ae into main Jun 19, 2025
25 checks passed
@benfdking benfdking deleted the fixing_uv_pip branch June 19, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants