fix(vscode): allow uv pip executable called through tcloud#4766
Merged
fix(vscode): allow uv pip executable called through tcloud#4766
Conversation
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the getTcloudBin utility to return structured execution info (including env, workspace path, and args) instead of just a path, and updates all downstream execAsync calls to use the new SqlmeshExecInfo.
- Changed
getTcloudBinreturn type and injected Python environment variables - Updated all
execAsyncinvocations to passbinandenvfrom the new exec info - Refactored SQLMesh and LSP commands to use the unified execution format
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vscode/extension/src/utilities/sqlmesh/sqlmesh.ts | Updated getTcloudBin return type, built env, and adjusted all calls to use bin and env |
| vscode/extension/src/auth/auth.ts | Switched execAsync calls to use tcloudBin.value.bin and env |
Comments suppressed due to low confidence (2)
vscode/extension/src/utilities/sqlmesh/sqlmesh.ts:56
- [nitpick] The JSDoc comment still refers to returning a string path. Please update it to describe the new
SqlmeshExecInfo(including bin, workspacePath, env, and args).
* @returns The tcloud executable for the current Python environment.
vscode/extension/src/utilities/sqlmesh/sqlmesh.ts:72
- [nitpick] The new error branch for
getPythonEnvVariablesisn’t covered by existing tests—consider adding a unit test to verify that a failure in env variable resolution returns the expected error.
if (isErr(envVariables)) {
izeigerman
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uv