Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds a CI step to run the benchmark suite on Windows.
- Introduces a new
make benchmark-cistep after tests in the Windows job. - Ensures benchmarks are executed as part of the CI pipeline.
Comments suppressed due to low confidence (1)
.circleci/continue_config.yml:136
- Consider adding a
store_artifactsstep after this to upload benchmark outputs (e.g., CSV or JSON) so results can be inspected and tracked over time.
command: make benchmark-ci
georgesittas
approved these changes
Jun 16, 2025
benfdking
force-pushed
the
run_benchmark_in_windows
branch
4 times, most recently
from
bf99d1e to
e698d24
Compare
benfdking
force-pushed
the
run_benchmark_in_windows
branch
from
e698d24 to
7e22eae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.