chore: dispose correctly in lineage panel#4740
Merged
Conversation
themisvaltinos
approved these changes
Jun 15, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that all event listeners and message handlers in the LineagePanel are tracked and properly disposed to prevent leaks.
- Introduces a
disposeablesarray to collect and manageDisposableinstances. - Registers workspace and editor listeners along with the webview message handler into
disposeables. - Updates
_extensionUritoextensionUriand adjusts related resource URI calls.
benfdking
force-pushed
the
disposing_correctly
branch
from
39c5604 to
0e1edb6
Compare
benfdking
changed the title
benfdking
force-pushed
the
disposing_correctly
branch
from
0e1edb6 to
55bc0a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.