chore(vscode): add test for non installation of deps'#4735
Merged
Conversation
906fd7a to
80151cc
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds utilities for creating and populating Python virtual environments in the test suite, refactors existing tests to use these helpers, and introduces a new test to ensure users are prompted when LSP dependencies are missing.
- Extracted venv creation and package installation into
createVirtualEnvironmentandpipInstall. - Updated
tcloud.spec.tsto use the new helpers. - Added
no_lsp.spec.tsto verify the “Install” prompt appears when LSP extras aren’t installed.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vscode/extension/tests/utils.ts | Added execAsync, createVirtualEnvironment, and pipInstall. |
| vscode/extension/tests/tcloud.spec.ts | Replaced inline venv and pip calls with the new helpers. |
| vscode/extension/tests/no_lsp.spec.ts | New test to check UI prompt for missing LSP dependencies. |
Comments suppressed due to low confidence (3)
vscode/extension/tests/utils.ts:127
- Update the JSDoc for
pipInstallto reflect that it accepts multiple packages: change the description to 'Install packages in the given virtual environment.' and update@param packagePathto@param packagePaths(string[]).
* @param packagePath The path to the package to install.
vscode/extension/tests/tcloud.spec.ts:25
- [nitpick] The variable name
custom_materializationsuses snake_case in a TypeScript codebase; consider renaming tocustomMaterializationsfor consistency with camelCase conventions.
const custom_materializations = path.join(
vscode/extension/tests/no_lsp.spec.ts:13
- The test title refers to signing in but the logic checks for missing LSP dependencies; consider renaming to something like 'missing LSP dependencies shows install prompt' to match the test behavior.
test('not signed in, shows sign in window', async ({}, testInfo) => {
80151cc to
19f214c
Compare
themisvaltinos
approved these changes
Jun 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.