fix(vscode): improve the tcloud stability#4734
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve tcloud stability within the VS Code extension by adding a mock tcloud CLI, improving installation flows for enterprise messaging (including a lock mechanism), cleaning up obsolete functionality, and updating recommended extensions.
- Introduces a REPO_ROOT constant for test utilities.
- Adds a comprehensive mock tcloud CLI (with pyproject.toml, CLI, README, and tests).
- Implements a lock mechanism in sqlmesh installation and removes an unused LSP did_change handler.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vscode/extension/tests/utils.ts | Added REPO_ROOT constant for computing repository root. |
| vscode/extension/tests/tcloud/pyproject.toml | New configuration for the mock tcloud package. |
| vscode/extension/tests/tcloud/mock_tcloud/cli.py | New mock tcloud CLI implementation for testing purposes. |
| vscode/extension/tests/tcloud/mock_tcloud/init.py | Minimal package initialization for the mock tcloud CLI. |
| vscode/extension/tests/tcloud/README.md | Documentation for the mock tcloud CLI usage in tests. |
| vscode/extension/tests/tcloud.spec.ts | Integration tests for tcloud flows via mock CLI and VS Code. |
| vscode/extension/src/utilities/sqlmesh/sqlmesh.ts | Added lock mechanism for sqlmesh installation and updated progress message. |
| tooling/vscode/extensions.json | Updated recommended extensions to include prettier. |
| sqlmesh/lsp/main.py | Removed the unused did_change handler and refactored context lookup. |
Comments suppressed due to low confidence (1)
sqlmesh/lsp/main.py:294
- [nitpick] The removal of the did_change handler appears intentional; please ensure that diagnostic updates on document changes are managed by alternative mechanisms to maintain LSP functionality.
@self.server.feature(types.TEXT_DOCUMENT_DID_CHANGE)
benfdking
force-pushed
the
adding_mock_tcloud_for_testing
branch
2 times, most recently
from
239097b to
cacf4fd
Compare
- add mock tcloud for testing tcloud flows - improved installing enterprise messaging - added lock around the tcloud install process to make more stable - removed unneedded lsp function that was causing issues
benfdking
force-pushed
the
adding_mock_tcloud_for_testing
branch
from
cacf4fd to
c0e271a
Compare
themisvaltinos
approved these changes
Jun 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.