Fix: Import validation for the snowflake connection config#4723
Merged
izeigerman merged 1 commit intomainfrom Jun 13, 2025
Merged
Fix: Import validation for the snowflake connection config#4723izeigerman merged 1 commit intomainfrom
izeigerman merged 1 commit intomainfrom
Conversation
georgesittas
approved these changes
Jun 12, 2025
Comment on lines
+569
to
+571
| _engine_import_validator = _get_engine_import_validator( | ||
| "snowflake.connector.network", "snowflake" | ||
| ) |
Collaborator
There was a problem hiding this comment.
FMI, how does moving this affect the execution / validation order? Asking based on this bit in the description:
Additionally, rearranged the model validators so that the import validator always runs first.
Collaborator
Author
There was a problem hiding this comment.
We want this to run before _validate_authenticator which uses the imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that the top-level
snowflakeimport is sometimes not enough to accurately conclude whether the required library has been installed or not.Additionally, rearranged the model validators so that the import validator always runs first.