feat: macro autocomplete has descriptions#4712
Merged
Conversation
benfdking
commented
Jun 11, 2025
benfdking
commented
Jun 11, 2025
benfdking
force-pushed
the
codex/add-extra-details-to-autocomplete-suggestions
branch
from
8d4f871 to
fcfa8ef
Compare
benfdking
changed the title
georgesittas
approved these changes
Jun 11, 2025
themisvaltinos
approved these changes
Jun 11, 2025
benfdking
deleted the
codex/add-extra-details-to-autocomplete-suggestions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MacroCompletionwith optional docstringTesting
pre-commit run --files sqlmesh/lsp/completions.py sqlmesh/lsp/custom.py sqlmesh/lsp/main.py tests/lsp/test_completions.pypytest tests/lsp/test_completions.py::test_get_macros -qhttps://chatgpt.com/codex/tasks/task_e_68493f049d348330899ab339336e981a