feat(lsp): custom methods always return errors#4708
Merged
Conversation
benfdking
force-pushed
the
improving_error_handling_in_server
branch
from
32666cd to
1c12e62
Compare
benfdking
force-pushed
the
improving_error_handling_in_server
branch
from
1c12e62 to
3147b42
Compare
themisvaltinos
approved these changes
Jun 10, 2025
| return FormatProjectResponse() | ||
| except Exception as e: | ||
| ls.log_trace(f"Error formatting project: {e}") | ||
| return FormatProjectResponse() |
Collaborator
There was a problem hiding this comment.
why do we return response on error instead of raising?
|
|
||
| class ApiResponseGetModels(PydanticModel): | ||
| class BaseAPIResponse(CustomMethodResponseBaseClass): | ||
| error: t.Optional[str] = None |
Collaborator
There was a problem hiding this comment.
why is error needed here and why is response_error not enough? I wen thought the code but can't understand its purpose of inheriting from CustomMethodResponseBaseClass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.