Skip to content

Chore!: bump sqlglot to v26.26.0 #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgesittas merged 1 commit into from
Jun 11, 2025
Merged

Chore!: bump sqlglot to v26.26.0 #4695

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies = [
"requests",
"rich[jupyter]",
"ruamel.yaml",
"sqlglot[rs]~=26.25.3",
"sqlglot[rs]~=26.26.0",
"tenacity",
"time-machine",
"json-stream"
Expand Down
3 changes: 0 additions & 3 deletions tests/core/test_dialect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,9 +643,6 @@ def test_model_normalization_quote_flexibility():
normalize_model_name('"catalog"."db"."table"', default_catalog=None, dialect="spark")
== '"catalog"."db"."table"'
)
# It doesn't work the other way which is what we currently expect
with pytest.raises(ParseError):
normalize_model_name("`catalog`.`db`.`table`", default_catalog=None, dialect=None)
Comment on lines -646 to -648
Copy link
Copy Markdown
Collaborator Author

@georgesittas georgesittas Jun 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is due to this commit. The normalize_model_name helper relies on to_table under the hood, which is now more lenient and doesn't fail despite the presence of backticks & absence of a dialect like "bigquery".

Basically, the behavior introduced by that sqlglot change is that this table name now literally includes the backticks in the table parts.



def test_macro_parse():
Expand Down