Skip to content

Enhances MSSQL connection with pyodbc support v2#4686

Merged
erindru merged 7 commits intoSQLMesh:mainfrom
mattiasthalen:add-pyodbc-option-to-mssql-v2
Jun 12, 2025
Merged

Enhances MSSQL connection with pyodbc support v2#4686
erindru merged 7 commits intoSQLMesh:mainfrom
mattiasthalen:add-pyodbc-option-to-mssql-v2

Conversation

@mattiasthalen
Copy link
Copy Markdown
Contributor

Adds support for pyodbc as an alternative driver for MSSQL connections, providing users with more flexibility and authentication options.

  • Introduces a driver option to choose between pymssql and pyodbc.
  • Implements connection string generation for pyodbc based on connection parameters.
  • Includes validation for different authentication methods when using pyodbc.
  • Updates dependencies to include pyodbc.

NOTE Had to create a new PR, the merge conflicts was gnarly, easier to just restart.
Replaces PR #4335

@mattiasthalen mattiasthalen force-pushed the add-pyodbc-option-to-mssql-v2 branch from 5e1f32a to c04fe30 Compare June 6, 2025 23:02
@mattiasthalen mattiasthalen marked this pull request as ready for review June 6, 2025 23:15
@erindru
Copy link
Copy Markdown
Collaborator

erindru commented Jun 8, 2025

Nice work!

Comment thread sqlmesh/core/config/connection.py Outdated
@mattiasthalen mattiasthalen force-pushed the add-pyodbc-option-to-mssql-v2 branch from c04fe30 to e896e09 Compare June 9, 2025 07:41
Comment thread sqlmesh/core/config/connection.py Outdated
@mattiasthalen mattiasthalen force-pushed the add-pyodbc-option-to-mssql-v2 branch from 185317d to 3851eb0 Compare June 11, 2025 21:07
@mattiasthalen mattiasthalen force-pushed the add-pyodbc-option-to-mssql-v2 branch from ab14c84 to 9c5889b Compare June 12, 2025 00:03
Copy link
Copy Markdown
Collaborator

@erindru erindru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me! Looks great!

@erindru erindru merged commit e3bf211 into SQLMesh:main Jun 12, 2025
21 checks passed
@mattiasthalen mattiasthalen deleted the add-pyodbc-option-to-mssql-v2 branch June 12, 2025 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants