Skip to content

feat: add macros to LSP completion#4667

Merged
benfdking merged 1 commit intomainfrom
codex/add-macros-to-autocompletions
Jun 9, 2025
Merged

feat: add macros to LSP completion#4667
benfdking merged 1 commit intomainfrom
codex/add-macros-to-autocompletions

Conversation

@benfdking
Copy link
Copy Markdown
Contributor

Summary

  • expose macros in AllModelsResponse
  • include macros in Python/TypeScript completion handling
  • test that macros show in completions

Testing

  • pytest -q (fails: ModuleNotFoundError: No module named 'pymysql')

https://chatgpt.com/codex/tasks/task_e_6841b7a645948330889be83831471693

Comment thread sqlmesh/lsp/completions.py Outdated
@benfdking benfdking changed the title Add macros to LSP completion feat: add macros to LSP completion Jun 8, 2025
@benfdking benfdking force-pushed the codex/add-macros-to-autocompletions branch 2 times, most recently from 9d7623e to 8f290b0 Compare June 9, 2025 10:42
Comment thread sqlmesh/lsp/completions.py
Comment thread sqlmesh/lsp/main.py Outdated
- do not include them in legacy vscode methods
- add autocomplete
@benfdking benfdking force-pushed the codex/add-macros-to-autocompletions branch from 8f290b0 to fbf0070 Compare June 9, 2025 12:33
@benfdking benfdking merged commit 7dd52c5 into main Jun 9, 2025
25 checks passed
@benfdking benfdking deleted the codex/add-macros-to-autocompletions branch June 9, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants