Skip to content

Commit 878fdf1

Browse files
committed
temp
1 parent a195ed2 commit 878fdf1

1 file changed

Lines changed: 15 additions & 13 deletions

File tree

vscode/extension/tests/bad_setup.spec.ts

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -75,19 +75,11 @@ test('missing LSP dependencies shows install prompt', async ({}, testInfo) => {
7575
})
7676

7777
test('lineage, no sqlmesh found', async ({}, testInfo) => {
78-
testInfo.setTimeout(120_000) // 2 minutes for venv creation and package installation
7978
const tempDir = await fs.mkdtemp(
8079
path.join(os.tmpdir(), 'vscode-test-tcloud-'),
8180
)
8281
const pythonEnvDir = path.join(tempDir, '.venv')
8382
const pythonDetails = await createVirtualEnvironment(pythonEnvDir)
84-
const custom_materializations = path.join(
85-
REPO_ROOT,
86-
'examples',
87-
'custom_materializations',
88-
)
89-
const sqlmeshWithExtras = `${REPO_ROOT}[bigquery]`
90-
await pipInstall(pythonDetails, [sqlmeshWithExtras, custom_materializations])
9183

9284
try {
9385
// Copy sushi project
@@ -110,16 +102,26 @@ test('lineage, no sqlmesh found', async ({}, testInfo) => {
110102
// Open lineage view
111103
await openLineageView(window)
112104

113-
await window.waitForTimeout(1_000)
105+
// Assert shows that sqlmesh is not installed
106+
await window.waitForSelector('text=SQLMesh language server not found')
114107

115-
// Assert cannot see the Loading models text
108+
// Assert cannot see wrong notifications
109+
await expect(window.locator('LSP dependencies missing')).not.toBeVisible()
110+
111+
// Cancel the notification
112+
await window.getByRole('button', { name: 'Cancel' }).click()
113+
114+
// When cancel notification, the lineage view should show the error
116115
await expect(
117-
window.locator('text=Loading models...'),
118-
).not.toBeVisible()
116+
window.locator('text=SQLMesh language server not found'),
117+
).toBeVisible()
118+
119+
// Assert cannot see the Loading models text
120+
await expect(window.locator('text=Loading models...')).not.toBeVisible()
119121

120122
await close()
121123
} finally {
122124
// Clean up
123125
await fs.remove(tempDir)
124126
}
125-
})
127+
})

0 commit comments

Comments
 (0)