chore: further testing error scenarios

Author: benfdking

vscode/extension/tests/no_lsp.spec.ts vscode/extension/tests/bad_setup.spec.tsvscode/extension/tests/no_lsp.spec.ts renamed to vscode/extension/tests/bad_setup.spec.ts

@@ -4,6 +4,7 @@ import os from 'os'
 import path from 'path'
 import {
   createVirtualEnvironment,
+  openLineageView,
   pipInstall,
   REPO_ROOT,
   startVSCode,
@@ -72,3 +73,53 @@ test('missing LSP dependencies shows install prompt', async ({}, testInfo) => {
     await fs.remove(tempDir)
   }
 })
+
+test('lineage, no sqlmesh found', async ({}, testInfo) => {
+  testInfo.setTimeout(120_000) // 2 minutes for venv creation and package installation
+  const tempDir = await fs.mkdtemp(
+    path.join(os.tmpdir(), 'vscode-test-tcloud-'),
+  )
+  const pythonEnvDir = path.join(tempDir, '.venv')
+  const pythonDetails = await createVirtualEnvironment(pythonEnvDir)
+  const custom_materializations = path.join(
+    REPO_ROOT,
+    'examples',
+    'custom_materializations',
+  )
+  const sqlmeshWithExtras = `${REPO_ROOT}[bigquery]`
+  await pipInstall(pythonDetails, [sqlmeshWithExtras, custom_materializations])
+
+  try {
+    // Copy sushi project
+    await fs.copy(SUSHI_SOURCE_PATH, tempDir)
+
+    // Configure VS Code settings to use our Python environment
+    const settings = {
+      'python.defaultInterpreterPath': pythonDetails.pythonPath,
+      'sqlmesh.environmentPath': pythonEnvDir,
+    }
+    await fs.ensureDir(path.join(tempDir, '.vscode'))
+    await fs.writeJson(
+      path.join(tempDir, '.vscode', 'settings.json'),
+      settings,
+      { spaces: 2 },
+    )
+
+    const { window, close } = await startVSCode(tempDir)
+
+    // Open lineage view
+    await openLineageView(window)
+
+    await window.waitForTimeout(1_000)
+
+    // Assert cannot see the Loading models text
+    await expect(
+      window.locator('text=Loading models...'),
+    ).not.toBeVisible()
+
+    await close()
+  } finally {
+    // Clean up
+    await fs.remove(tempDir)
+  }
+})

vscode/extension/tests/lineage.spec.ts

@@ -2,19 +2,14 @@ import { test, expect, Page } from '@playwright/test'
 import path from 'path'
 import fs from 'fs-extra'
 import os from 'os'
-import { startVSCode, SUSHI_SOURCE_PATH } from './utils'
+import { openLineageView, startVSCode, SUSHI_SOURCE_PATH } from './utils'
 import { writeFileSync } from 'fs'
 
 /**
  * Helper function to launch VS Code and test lineage with given project path config
  */
 async function testLineageWithProjectPath(window: Page): Promise<void> {
-  // Trigger lineage command
-  await window.keyboard.press(
-    process.platform === 'darwin' ? 'Meta+Shift+P' : 'Control+Shift+P',
-  )
-  await window.keyboard.type('Lineage: Focus On View')
-  await window.keyboard.press('Enter')
+  await openLineageView(window)
 
   // Wait for "Loaded SQLMesh context" text to appear
   const loadedContextText = window.locator('text=Loaded SQLMesh context')

vscode/extension/tests/utils.ts

@@ -137,3 +137,14 @@ export const pipInstall = async (
     throw new Error(`Failed to install package: ${stderr}`)
   }
 }
+
+/**
+ * Open the lineage view in the given window.
+ */
+export const openLineageView = async (window: Page): Promise<void> => {
+  await window.keyboard.press(
+    process.platform === 'darwin' ? 'Meta+Shift+P' : 'Control+Shift+P',
+  )
+  await window.keyboard.type('Lineage: Focus On View')
+  await window.keyboard.press('Enter')
+}