Fix: Always support start_* / end_* macros in pre- / post- statements (#4025)

Author: izeigerman

sqlmesh/core/model/definition.py

@@ -584,7 +584,7 @@ def _statement_renderer(self, expression: exp.Expression) -> ExpressionRenderer:
                 path=self._path,
                 jinja_macro_registry=self.jinja_macros,
                 python_env=self.python_env,
-                only_execution_time=self.kind.only_execution_time,
+                only_execution_time=False,
                 default_catalog=self.default_catalog,
                 model_fqn=self.fqn,
             )

tests/core/test_model.py

@@ -716,6 +716,8 @@ def test_macro(**kwargs) -> None:
 
 
 def test_model_pre_post_statements():
+    macro.registry().pop("foo", None)
+
     @macro()
     def foo(**kwargs) -> None:
         pass
@@ -776,6 +778,46 @@ def multiple_statements(evaluator, t1_value=exp.Literal.number(1)):
     assert "exp" in model.python_env
 
 
+@pytest.mark.parametrize("model_kind", ["FULL", "VIEW"])
+def test_model_pre_post_statements_start_end_are_always_available(model_kind: str):
+    macro.registry().pop("foo", None)
+    macro.registry().pop("bar", None)
+
+    @macro()
+    def foo(evaluator: MacroEvaluator, start: str, end: str) -> str:
+        return f"'{start}, {end}'"
+
+    @macro()
+    def bar(evaluator: MacroEvaluator, start: int, end: int) -> str:
+        return f"'{start}, {end}'"
+
+    expressions = d.parse(
+        f"""
+        MODEL (
+            name db.table,
+            kind {model_kind},
+        );
+
+        @foo(@start_ds, @end_ds);
+
+        SELECT 1 AS x;
+
+        @bar(@start_millis, @end_millis);
+    """
+    )
+    model = load_sql_based_model(expressions)
+
+    start = "2025-01-01"
+    end = "2025-01-02"
+
+    assert model.render_pre_statements(start=start, end=end) == [
+        exp.Literal.string(f"{start}, {end}")
+    ]
+    assert model.render_post_statements(start=start, end=end) == [
+        exp.Literal.string(f"{to_timestamp(start)}, {to_timestamp('2025-01-03') - 1}")
+    ]
+
+
 def test_seed_hydration():
     expressions = d.parse(
         """
@@ -1030,6 +1072,8 @@ def test_seed_marker_substitution():
 
 
 def test_seed_pre_post_statements():
+    macro.registry().pop("bar", None)
+
     @macro()
     def bar(**kwargs) -> None:
         pass