Skip to content

Commit 775936b

Browse files
authored
Fix: Using empty set as a default argument value (#4022)
1 parent 0bb482a commit 775936b

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

sqlmesh/core/snapshot/evaluator.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ def create(
280280
deployability_index: t.Optional[DeployabilityIndex] = None,
281281
on_start: t.Optional[t.Callable] = None,
282282
on_complete: t.Optional[t.Callable[[SnapshotInfoLike], None]] = None,
283-
allow_destructive_snapshots: t.Set[str] = set(),
283+
allow_destructive_snapshots: t.Optional[t.Set[str]] = None,
284284
) -> None:
285285
"""Creates a physical snapshot schema and table for the given collection of snapshots.
286286
@@ -296,6 +296,7 @@ def create(
296296
tables_by_schema = defaultdict(set)
297297
gateway_by_schema: t.Dict[exp.Table, str] = {}
298298
table_deployability: t.Dict[str, bool] = {}
299+
allow_destructive_snapshots = allow_destructive_snapshots or set()
299300

300301
for snapshot in target_snapshots:
301302
if not snapshot.is_model or snapshot.is_symbolic:
@@ -388,7 +389,7 @@ def migrate(
388389
self,
389390
target_snapshots: t.Iterable[Snapshot],
390391
snapshots: t.Dict[SnapshotId, Snapshot],
391-
allow_destructive_snapshots: t.Set[str] = set(),
392+
allow_destructive_snapshots: t.Optional[t.Set[str]] = None,
392393
deployability_index: t.Optional[DeployabilityIndex] = None,
393394
) -> None:
394395
"""Alters a physical snapshot table to match its snapshot's schema for the given collection of snapshots.
@@ -399,6 +400,7 @@ def migrate(
399400
allow_destructive_snapshots: Set of snapshots that are allowed to have destructive schema changes.
400401
deployability_index: Determines snapshots that are deployable in the context of this evaluation.
401402
"""
403+
allow_destructive_snapshots = allow_destructive_snapshots or set()
402404
deployability_index = deployability_index or DeployabilityIndex.all_deployable()
403405
with self.concurrent_context():
404406
concurrent_apply_to_snapshots(

0 commit comments

Comments
 (0)