Skip to content

Commit 2d9102a

Browse files
Apply suggestions from code review
Co-authored-by: Sung Won Chung <sungwonchung3@gmail.com>
1 parent f91749f commit 2d9102a

1 file changed

Lines changed: 5 additions & 3 deletions

File tree

docs/guides/tablediff.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -140,8 +140,10 @@ When diffing multiple models, SQLMesh will:
140140

141141
The `--select-model` option supports a powerful selection syntax that lets you choose models using patterns, tags, dependencies and git status. For complete details, see the [model selection guide](./model_selection.md).
142142

143-
Here are some common patterns you can use:
143+
> Note: models will only be data diffed if there's a breaking change that impacts them.
144144
145+
Here are some common patterns you can use:
146+
> Note: Surround your selection pattern in single or double quotes. Ex: '*', "sqlmesh_example.*"
145147
### Wildcard Patterns
146148
- `*` - All models in the project
147149
- `sqlmesh_example.*` - All models in the sqlmesh_example schema
@@ -187,9 +189,9 @@ sqlmesh table_diff prod:dev -m "tag:finance" -m "metrics.*_daily"
187189

188190
When multiple selectors are provided, they are combined with OR logic, meaning a model matching any of the selectors will be included.
189191

190-
All the standard table diff options like `--show-sample` work with multiple model diffing. The comparisons are executed concurrently for better performance when dealing with a large of project or many models.
192+
All the standard table diff options like `--show-sample` work with multiple model diffing. The comparisons are executed concurrently for better performance when dealing with a large project or many models.
191193

192-
> Note: All models being compared must have their `grain` defined, as this is used to perform the join between the tables in the two environments.
194+
> Note: All models being compared must have their `grain` defined that is unique and not null, as this is used to perform the join between the tables in the two environments.
193195
194196
## Diffing tables or views
195197

0 commit comments

Comments
 (0)