clean up logic for non existing models per env; revise doc

Author: themisvaltinos

docs/guides/tablediff.md

@@ -135,10 +135,8 @@ sqlmesh table_diff prod:dev --select-model "sqlmesh_example.*"
 
 When diffing multiple models, SQLMesh will:
 
-1. Show which models exist only in the source environment
-2. Show which models exist only in the target environment
-3. Show which models exist in both environments but have no differences
-4. Compare the models that have differences and display them
+1. Show the models returnes by the selector that exist in both environments, but have no differences
+2. Compare the models that have differences and display the table diff of each model
 
 The `--select-model` option supports a powerful selection syntax that lets you choose models using patterns, tags, dependencies and git status. For complete details, see the [model selection guide](./model_selection.md).
 

sqlmesh/core/console.py

@@ -250,8 +250,6 @@ def stop_table_diff_progress(self, success: bool) -> None:
     @abc.abstractmethod
     def show_table_diff_details(
         self,
-        models_in_source: t.List[str],
-        models_in_target: t.List[str],
         models_no_diff: t.List[str],
         models_to_diff: t.List[str],
     ) -> None:
@@ -719,8 +717,6 @@ def stop_table_diff_progress(self, success: bool) -> None:
 
     def show_table_diff_details(
         self,
-        models_in_source: t.List[str],
-        models_in_target: t.List[str],
         models_no_diff: t.List[str],
         models_to_diff: t.List[str],
     ) -> None:
@@ -1987,25 +1983,11 @@ def loading_stop(self, id: uuid.UUID) -> None:
 
     def show_table_diff_details(
         self,
-        models_in_source: t.List[str],
-        models_in_target: t.List[str],
         models_no_diff: t.List[str],
         models_to_diff: t.List[str],
     ) -> None:
         """Display information about which tables are identical and which are diffed"""
 
-        if models_in_source:
-            m_tree = Tree("\n[b]Models only in source environment:")
-            for m in models_in_source:
-                m_tree.add(f"[{self.TABLE_DIFF_SOURCE_BLUE}]{m}[/{self.TABLE_DIFF_SOURCE_BLUE}]")
-            self._print(m_tree)
-
-        if models_in_target:
-            m_tree = Tree("\n[b]Models only in target environment:")
-            for m in models_in_target:
-                m_tree.add(f"[{self.TABLE_DIFF_TARGET_GREEN}]{m}[/{self.TABLE_DIFF_TARGET_GREEN}]")
-            self._print(m_tree)
-
         if models_no_diff:
             m_tree = Tree("\n[b]Models without changes:")
             for m in models_no_diff:

sqlmesh/core/context.py

@@ -1625,8 +1625,6 @@ def table_diff(
             models_to_diff: t.List[
                 t.Tuple[Model, EngineAdapter, str, str, t.Optional[t.List[str] | exp.Condition]]
             ] = []
-            models_in_source: t.List[str] = []
-            models_in_target: t.List[str] = []
             models_no_diff: t.List[str] = []
             models_without_grain: t.List[Model] = []
             source_snapshots_to_name = {
@@ -1642,11 +1640,7 @@ def table_diff(
                 source_snapshot = source_snapshots_to_name.get(model.fqn)
                 target_snapshot = target_snapshots_to_name.get(model.fqn)
 
-                if source_snapshot is None and target_snapshot:
-                    models_in_source.append(model_fqn)
-                elif target_snapshot is None and source_snapshot:
-                    models_in_target.append(model_fqn)
-                elif target_snapshot and source_snapshot:
+                if target_snapshot and source_snapshot:
                     if (
                         source_snapshot.fingerprint.data_hash
                         != target_snapshot.fingerprint.data_hash
@@ -1667,8 +1661,6 @@ def table_diff(
                         models_no_diff.append(model_fqn)
 
             self.console.show_table_diff_details(
-                models_in_source,
-                models_in_target,
                 models_no_diff,
                 [model[0].name for model in models_to_diff],
             )