feat: add linting to the lsp

[ci skip]

Author: benfdking

examples/sushi/config.py

@@ -13,6 +13,7 @@
     PlanConfig,
     SparkConnectionConfig,
 )
+from sqlmesh.core.config.linter import LinterConfig
 from sqlmesh.core.notification_target import (
     BasicSMTPNotificationTarget,
     SlackApiNotificationTarget,
@@ -41,6 +42,15 @@
     },
     default_gateway="duckdb",
     model_defaults=model_defaults,
+    linter=LinterConfig(
+        enabled=False,
+        rules=[
+            "ambiguousorinvalidcolumn",
+            "invalidselectstarexpansion",
+            "noselectstar",
+            "nomissingaudits",
+        ],
+    ),
 )
 
 bigquery_config = Config(

sqlmesh/core/context.py

@@ -76,7 +76,7 @@
 from sqlmesh.core.engine_adapter import EngineAdapter
 from sqlmesh.core.environment import Environment, EnvironmentNamingInfo, EnvironmentStatements
 from sqlmesh.core.loader import Loader
-from sqlmesh.core.linter.definition import Linter
+from sqlmesh.core.linter.definition import AnnotatedRuleViolation, Linter
 from sqlmesh.core.linter.rules import BUILTIN_RULES
 from sqlmesh.core.macros import ExecutableOrMacro, macro
 from sqlmesh.core.metric import Metric, rewrite
@@ -2461,22 +2461,29 @@ def _get_models_for_interval_end(
     def lint_models(
         self,
         models: t.Optional[t.Iterable[t.Union[str, Model]]] = None,
-    ) -> None:
+        raise_on_error: bool = True,
+    ) -> t.List[AnnotatedRuleViolation]:
         found_error = False
 
         model_list = (
             list(self.get_model(model) for model in models) if models else self.models.values()
         )
+        all_violations = []
         for model in model_list:
             # Linter may be `None` if the context is not loaded yet
             if linter := self._linters.get(model.project):
-                found_error = linter.lint_model(model, console=self.console) or found_error
+                found_error, violations = (
+                    linter.lint_model(model, console=self.console) or found_error
+                )
+                all_violations.extend(violations)
 
-        if found_error:
+        if raise_on_error and found_error:
             raise LinterError(
                 "Linter detected errors in the code. Please fix them before proceeding."
             )
 
+        return all_violations
+
     def load_model_tests(
         self, tests: t.Optional[t.List[str]] = None, patterns: list[str] | None = None
     ) -> t.List[ModelTestMetadata]:

sqlmesh/core/linter/definition.py

@@ -9,6 +9,7 @@
 from functools import reduce
 from sqlmesh.core.model import Model
 from sqlmesh.core.linter.rule import Rule, RuleViolation
+from sqlmesh.core.console import LinterConsole, get_console
 
 
 def select_rules(all_rules: RuleSet, rule_names: t.Set[str]) -> RuleSet:
@@ -50,9 +51,11 @@ def from_rules(cls, all_rules: RuleSet, config: LinterConfig) -> Linter:
 
         return Linter(config.enabled, all_rules, rules, warn_rules)
 
-    def lint_model(self, model: Model, console: LinterConsole = get_console()) -> bool:
+    def lint_model(
+        self, model: Model, console: LinterConsole = get_console()
+    ) -> t.Tuple[bool, t.List[AnnotatedRuleViolation]]:
         if not self.enabled:
-            return False
+            return False, []
 
         ignored_rules = select_rules(self.all_rules, model.ignored_rules)
 
@@ -62,14 +65,31 @@ def lint_model(self, model: Model, console: LinterConsole = get_console()) -> bo
         error_violations = rules.check_model(model)
         warn_violations = warn_rules.check_model(model)
 
+        all_violations: t.List[AnnotatedRuleViolation] = [
+            AnnotatedRuleViolation(
+                rule=violation.rule,
+                violation_msg=violation.violation_msg,
+                model=model,
+                violation_type="error",
+            )
+            for violation in error_violations
+        ] + [
+            AnnotatedRuleViolation(
+                rule=violation.rule,
+                violation_msg=violation.violation_msg,
+                model=model,
+                violation_type="warning",
+            )
+            for violation in warn_violations
+        ]
+
         if warn_violations:
             console.show_linter_violations(warn_violations, model)
-
         if error_violations:
             console.show_linter_violations(error_violations, model, is_error=True)
-            return True
+            return True, all_violations
 
-        return False
+        return False, all_violations
 
 
 class RuleSet(Mapping[str, type[Rule]]):
@@ -117,3 +137,16 @@ def intersection(self, *others: RuleSet) -> RuleSet:
 
     def difference(self, *others: RuleSet) -> RuleSet:
         return reduce(lambda lhs, rhs: lhs.__op(op.sub, rhs), (self, *others))
+
+
+class AnnotatedRuleViolation(RuleViolation):
+    def __init__(
+        self,
+        rule: Rule,
+        violation_msg: str,
+        model: Model,
+        violation_type: t.Literal["error", "warning"],
+    ) -> None:
+        super().__init__(rule, violation_msg)
+        self.model = model
+        self.violation_type = violation_type

sqlmesh/core/linter/rule.py

@@ -2,7 +2,6 @@
 
 import abc
 
-
 from sqlmesh.core.model import Model
 
 from typing import Type