refactor: move ruleset into linter definition (#4166)

Author: benfdking

sqlmesh/core/linter/definition.py

@@ -1,14 +1,14 @@
 from __future__ import annotations
-
 import typing as t
-
 from sqlmesh.core.config.linter import LinterConfig
-
 from sqlmesh.core.model import Model
-
 from sqlmesh.utils.errors import raise_config_error
 from sqlmesh.core.console import LinterConsole, get_console
-from sqlmesh.core.linter.rule import RuleSet
+import operator as op
+from collections.abc import Iterator, Iterable, Set, Mapping, Callable
+from functools import reduce
+from sqlmesh.core.model import Model
+from sqlmesh.core.linter.rule import Rule, RuleViolation
 
 
 def select_rules(all_rules: RuleSet, rule_names: t.Set[str]) -> RuleSet:
@@ -70,3 +70,50 @@ def lint_model(self, model: Model, console: LinterConsole = get_console()) -> bo
             return True
 
         return False
+
+
+class RuleSet(Mapping[str, type[Rule]]):
+    def __init__(self, rules: Iterable[type[Rule]] = ()) -> None:
+        self._underlying = {rule.name: rule for rule in rules}
+
+    def check_model(self, model: Model) -> t.List[RuleViolation]:
+        violations = []
+
+        for rule in self._underlying.values():
+            violation = rule().check_model(model)
+
+            if violation:
+                violations.append(violation)
+
+        return violations
+
+    def __iter__(self) -> Iterator[str]:
+        return iter(self._underlying)
+
+    def __len__(self) -> int:
+        return len(self._underlying)
+
+    def __getitem__(self, rule: str | type[Rule]) -> type[Rule]:
+        key = rule if isinstance(rule, str) else rule.name
+        return self._underlying[key]
+
+    def __op(
+        self,
+        op: Callable[[Set[type[Rule]], Set[type[Rule]]], Set[type[Rule]]],
+        other: RuleSet,
+        /,
+    ) -> RuleSet:
+        rules = set()
+        for rule in op(set(self.values()), set(other.values())):
+            rules.add(other[rule] if rule in other else self[rule])
+
+        return RuleSet(rules)
+
+    def union(self, *others: RuleSet) -> RuleSet:
+        return reduce(lambda lhs, rhs: lhs.__op(op.or_, rhs), (self, *others))
+
+    def intersection(self, *others: RuleSet) -> RuleSet:
+        return reduce(lambda lhs, rhs: lhs.__op(op.and_, rhs), (self, *others))
+
+    def difference(self, *others: RuleSet) -> RuleSet:
+        return reduce(lambda lhs, rhs: lhs.__op(op.sub, rhs), (self, *others))

sqlmesh/core/linter/rule.py

@@ -2,9 +2,6 @@
 
 import abc
 
-import operator as op
-from collections.abc import Iterator, Iterable, Set, Mapping, Callable
-from functools import reduce
 
 from sqlmesh.core.model import Model
 
@@ -48,50 +45,3 @@ def __init__(self, rule: Rule, violation_msg: str) -> None:
 
     def __repr__(self) -> str:
         return f"{self.rule.name}: {self.violation_msg}"
-
-
-class RuleSet(Mapping[str, type[Rule]]):
-    def __init__(self, rules: Iterable[type[Rule]] = ()) -> None:
-        self._underlying = {rule.name: rule for rule in rules}
-
-    def check_model(self, model: Model) -> t.List[RuleViolation]:
-        violations = []
-
-        for rule in self._underlying.values():
-            violation = rule().check_model(model)
-
-            if violation:
-                violations.append(violation)
-
-        return violations
-
-    def __iter__(self) -> Iterator[str]:
-        return iter(self._underlying)
-
-    def __len__(self) -> int:
-        return len(self._underlying)
-
-    def __getitem__(self, rule: str | type[Rule]) -> type[Rule]:
-        key = rule if isinstance(rule, str) else rule.name
-        return self._underlying[key]
-
-    def __op(
-        self,
-        op: Callable[[Set[type[Rule]], Set[type[Rule]]], Set[type[Rule]]],
-        other: RuleSet,
-        /,
-    ) -> RuleSet:
-        rules = set()
-        for rule in op(set(self.values()), set(other.values())):
-            rules.add(other[rule] if rule in other else self[rule])
-
-        return RuleSet(rules)
-
-    def union(self, *others: RuleSet) -> RuleSet:
-        return reduce(lambda lhs, rhs: lhs.__op(op.or_, rhs), (self, *others))
-
-    def intersection(self, *others: RuleSet) -> RuleSet:
-        return reduce(lambda lhs, rhs: lhs.__op(op.and_, rhs), (self, *others))
-
-    def difference(self, *others: RuleSet) -> RuleSet:
-        return reduce(lambda lhs, rhs: lhs.__op(op.sub, rhs), (self, *others))

sqlmesh/core/linter/rules/builtin.py

@@ -6,7 +6,8 @@
 
 from sqlglot.helper import subclasses
 
-from sqlmesh.core.linter.rule import Rule, RuleViolation, RuleSet
+from sqlmesh.core.linter.rule import Rule, RuleViolation
+from sqlmesh.core.linter.definition import RuleSet
 from sqlmesh.core.model import Model, SqlModel
 
 

sqlmesh/core/loader.py

@@ -20,7 +20,8 @@
 from sqlmesh.core.audit import Audit, ModelAudit, StandaloneAudit, load_multiple_audits
 from sqlmesh.core.dialect import parse
 from sqlmesh.core.environment import EnvironmentStatements
-from sqlmesh.core.linter.rule import RuleSet, Rule
+from sqlmesh.core.linter.rule import Rule
+from sqlmesh.core.linter.definition import RuleSet
 from sqlmesh.core.macros import MacroRegistry, macro
 from sqlmesh.core.metric import Metric, MetricMeta, expand_metrics, load_metric_ddl
 from sqlmesh.core.model import (