Compilation problem on Macos/arm64

[sjunges]

Hi Steven,

I ran into the following problem trying to compile Dice.

[ERROR] The compilation of dice.~dev failed at "dune build -p dice -j 7".

#=== ERROR while compiling mlcuddidl.dev ======================================#
# context     2.5.0 | macos/arm64 | ocaml-base-compiler.4.10.2 | pinned(git+https://github.com/SHoltzen/mlcuddidil.git#master#f102c9ac23a3ded8e20b911f27125d111509757a)
# path        ~/.opam/4.10.2/.opam-switch/build/mlcuddidl.dev
# command     ~/.opam/opam-init/hooks/sandbox.sh build make -j7
# exit-code   2
# env-file    ~/.opam/log/mlcuddidl-41958-860813.env
# output-file ~/.opam/log/mlcuddidl-41958-860813.out
### output ###
# [...]
# /Users/junges/.opam/4.10.2/bin/ocamlopt.opt -I cudd-3.0.0 -I cudd-3.0.0/st -I cudd-3.0.0/mtr -I cudd-3.0.0/epd -I cudd-3.0.0/util -I cudd-3.0.0/cudd -I cuddsrc-base -I /Users/junges/.opam/4.10.2/lib/ocaml -I /Users/junges/.opam/4.10.2/lib/camlidl -ccopt "-fPIC -O3 -DDD_COUNT -o memo_caml.o"  -c memo_caml.c
# /Users/junges/.opam/4.10.2/bin/ocamlopt.opt -I cudd-3.0.0 -I cudd-3.0.0/st -I cudd-3.0.0/mtr -I cudd-3.0.0/epd -I cudd-3.0.0/util -I cudd-3.0.0/cudd -I cuddsrc-base -I /Users/junges/.opam/4.10.2/lib/ocaml -I /Users/junges/.opam/4.10.2/lib/camlidl -ccopt "-fPIC -O3 -DDD_COUNT -o man_caml.o"  -c man_caml.c
# /Users/junges/.opam/4.10.2/bin/ocamlopt.opt -I cudd-3.0.0 -I cudd-3.0.0/st -I cudd-3.0.0/mtr -I cudd-3.0.0/epd -I cudd-3.0.0/util -I cudd-3.0.0/cudd -I cuddsrc-base -I /Users/junges/.opam/4.10.2/lib/ocaml -I /Users/junges/.opam/4.10.2/lib/camlidl -ccopt "-fPIC -O3 -DDD_COUNT -o bdd_caml.o"  -c bdd_caml.c
# /Users/junges/.opam/4.10.2/bin/ocamlopt.opt -I cudd-3.0.0 -I cudd-3.0.0/st -I cudd-3.0.0/mtr -I cudd-3.0.0/epd -I cudd-3.0.0/util -I cudd-3.0.0/cudd -I cuddsrc-base -I /Users/junges/.opam/4.10.2/lib/ocaml -I /Users/junges/.opam/4.10.2/lib/camlidl -ccopt "-fPIC -O3 -DDD_COUNT -o vdd_caml.o"  -c vdd_caml.c
# /Users/junges/.opam/4.10.2/bin/ocamlopt.opt -I cudd-3.0.0 -I cudd-3.0.0/st -I cudd-3.0.0/mtr -I cudd-3.0.0/epd -I cudd-3.0.0/util -I cudd-3.0.0/cudd -I cuddsrc-base -I /Users/junges/.opam/4.10.2/lib/ocaml -I /Users/junges/.opam/4.10.2/lib/camlidl -ccopt "-fPIC -O3 -DDD_COUNT -o custom_caml.o"  -c custom_caml.c
# /Users/junges/.opam/4.10.2/bin/ocamlopt.opt -I cudd-3.0.0 -I cudd-3.0.0/st -I cudd-3.0.0/mtr -I cudd-3.0.0/epd -I cudd-3.0.0/util -I cudd-3.0.0/cudd -I cuddsrc-base -I /Users/junges/.opam/4.10.2/lib/ocaml -I /Users/junges/.opam/4.10.2/lib/camlidl -ccopt "-fPIC -O3 -DDD_COUNT -o add_caml.o"  -c add_caml.c
# custom_caml.c:148:14: error: incompatible pointer to integer conversion assigning to 'value' (aka 'long') from 'void *' [-Wint-conversion]
#   (*_c2).exn = NULL;
#              ^ ~~~~
# 1 error generated.
# make: *** [custom_caml.o] Error 2
# make: *** Waiting for unfinished jobs....

[kitsu418]

Hi Sebastian,

I hit the same issue on my ARM Mac. What fixed it for me was removing the exn field from custom.idl:

@@ -27,7 +27,6 @@ struct common {
   int arity;
   struct memo__t memo;
   [ignore] void* man;
-  [ignore] void* exn;
 };

and leave other code unchanged. That stops CamlIDL from generating (*_c2).exn = NULL;, while exn is still managed in the C code.

I’m not completely sure this is the best fix, but it solved the build issue for me.

[SHoltzen]

Ahah! Wow, this code is still alive... sorry for not being more responsive here.

@kitsu418 thanks for a quick workaround here. I do not have time this moment to validate this workaround, but if it works, Im happy to merge a pull request with this patch applied.