Feature: Add button for ending interviews#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When interviews are completed, interviewers need to be able to close the interview room so that the interviewee cannot retroactively edit their code to adjust their performance.
Implementation
This is implemented using a WebSocket message where, when the interviewer ends the interview, each other user in the room is notified that the interview was ended, each user is prompted to leave the room. Before that happens, all the code content is flushed to disk and the room is deleted from memory after all users leave. For security reasons, ending interviews is gated behind an API key modal, so that only admins with privileged information can end the interview.
Testing
This has been tested on a local setup with two users on the same machine, and the implementation worked as intended.