SBND Timing Reconstruction Refactor by VCLanNguyen · Pull Request #915 · SBNSoftware/sbndcode

VCLanNguyen · 2026-02-14T00:13:22Z

Description

Timing reconstruction is refactored in this PR, affecting the decode/reconstruction workflow of CRT/PMT/XA.
After the refactoring, the @FrameShiftModule@ runs first in the decode chain, outputs timing products to be used at PMT/XA decoder and CRTStrip reconstruction.
Relevant PMT reconstruction modules at Reco1/Reco2 are updated.
The timing correction applied at CAFMakeer is undone. - The timing correction applied at CAFMakeer is undone. This should ressolve this issue: Converge timing correction in CAFMaker for SBND and ICARUS sbncode#567
Details and validation plots can before in the linked docdb.

Link(s) to docdb describing changes (optional)

https://sbn-docdb.fnal.gov/cgi-bin/sso/ShowDocument?docid=46654

Relevant PR links (optional)

This PR needs the XA decoder PR in sbndcode to go in first:
#847

This PR needs to be merged together with this group of PRs:

sbndcode: SBND Timing Reconstruction Refactor #915
sbncode: SBND Timing Reconstruction Refactor sbncode#637
sbnobj: SBND Timing Reconstruction Refactor sbnobj#170
sbnanaobj:SBND Timing Reconstruction Refactor sbnanaobj#188

Checklist

Added at least 1 label from available labels.
Assigned at least 1 reviewer under Reviewers,
Assigned all contributers including yourself under Assignees
Linked any relevant issues under Developement
Does this PR affect CAF data format? If so, please assign a CAF maintainer (PetrilloAtWork or JosiePaton) as additional reviewer.
Does this affect the standard workflow?
Is this PR a patch for the ongoing production? If so, separate PR must also be made for production/v10_06_00 branch!

…v10_11_01_hlay_functions Functionalise

…/ptb

…v10_11_01_pmt_crt Add PMT/CRT decoder

…not all channels per CAEN

…b.com/SBNSoftware/sbndcode into feature/frameshift_refactor_v10_11_01

…b.com/SBNSoftware/sbndcode into feature/frame_shift_refactor_v10_14_02

…_fragments' into feature/aliciavr-XARAPUCA-offline-decoder-v5.0-frameshift-refactor

…ess its products. Additionally, set a frameshift mode boolean t be activated when selecting the frameshift timestamp (this one to be integrated in the workflow)

PetrilloAtWork · 2026-05-07T00:20:10Z

something that looks like a bug (which must be fixed, hence the rejection)

I think that was the resize() call that does not reset values to 0. That was fixed.

a questionable implementation of the difference of timestamps

That is the implementation of TimingUtils::SubtractUTCTimestmap(). I don't see my original comment any more... either GitHub ate it, or it never left my computer. It was something like:

How is this implementation different from:

double sbn::TimingUtils::SubtractUTCTimestmap(uint64_t ts1, uint64_t ts2) {
  return (ts1 > ts2)? (double)(ts1 - ts2): -(double)(ts2 - ts1);
}

VCLanNguyen · 2026-05-07T22:05:42Z

something that looks like a bug (which must be fixed, hence the rejection)

I think that was the resize() call that does not reset values to 0. That was fixed.

a questionable implementation of the difference of timestamps

That is the implementation of TimingUtils::SubtractUTCTimestmap(). I don't see my original comment any more... either GitHub ate it, or it never left my computer. It was something like:

How is this implementation different from:
double sbn::TimingUtils::SubtractUTCTimestmap(uint64_t ts1, uint64_t ts2) {
  return (ts1 > ts2)? (double)(ts1 - ts2): -(double)(ts2 - ts1);
}

I don't think it is any different. I just wrote it very convoluted originally so I could understand and did not look at it again... Updated now.

PetrilloAtWork · 2026-05-07T22:55:57Z

There are things to be careful of in that apparently simple difference (the conversion from unsigned operands to a signed difference, and the loss of precision from conversion to double), so if you want you may add a comment in the implementation in that regard.

PetrilloAtWork

Approved, and thanks.

VCLanNguyen · 2026-05-08T01:17:12Z

Hi @nathanielerowe reviewers approved all 4 PRs now so they are ready for CI test. Any suggestions on how to proceed?

…ift fcls

aantonakis · 2026-05-12T19:09:57Z

trigger build SBNSoftware/sbncode#637,SBNSoftware/sbnobj#170,SBNSoftware/sbnanaobj#188

FNALbuild · 2026-05-12T19:13:30Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T19:13:34Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T19:14:42Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-12T19:14:52Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-05-12T20:10:44Z

trigger build SBNSoftware/sbncode#637,SBNSoftware/sbnobj#170,SBNSoftware/sbnanaobj#188,LArSoft/LARSOFT_SUITE_v10_14_02

FNALbuild · 2026-05-12T20:25:30Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T20:34:38Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T20:35:24Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-12T20:44:03Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-05-12T21:16:44Z

trigger build SBNSoftware/sbncode#637,SBNSoftware/sbnobj#170,SBNSoftware/sbnanaobj#188,LArSoft/lar*@LARSOFT_SUITE_v10_14_02_02

FNALbuild · 2026-05-12T21:30:53Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T21:32:23Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T21:40:57Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-12T21:42:25Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

aantonakis · 2026-05-12T21:56:58Z

trigger build SBNSoftware/sbncode#637,SBNSoftware/sbnobj#170,SBNSoftware/sbnanaobj#188,LArSoft/lar*@LARSOFT_SUITE_v10_14_02

FNALbuild · 2026-05-12T22:09:40Z

✔️ CI build for LArSoft Succeeded on slf7 for c14:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T22:12:35Z

✔️ CI build for LArSoft Succeeded on slf7 for e26:prof -- details available through the CI dashboard

FNALbuild · 2026-05-12T22:15:23Z

❌ CI build for SBND Failed at phase build SBND on slf7 for c14:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

FNALbuild · 2026-05-12T22:21:42Z

❌ CI build for SBND Failed at phase build SBND on slf7 for e26:prof -- details available through the CI dashboard

🚨 For more details about the failed phase, check the build SBND phase logs

parent CI build details are available through the CI dashboard

VCLanNguyen and others added 30 commits November 11, 2025 16:24

refactor frameshift module to run at decode stage

f527fb8

add timing channel

7e7c3c4

add initialisation as max uint64_t

8d8d8a1

Use namespace and enumeration

daa63dc

Begin functionalisation

6739521

Make constexpr for regularly used cast

f7dead4

Make function for formatting timestamp

34e6ffe

Functionalise frame TDC/PTB definitions

500d130

Reduce duplication in final logic

a21b73f

Consistent indentation

4697328

Clean up fcl parameters and document

8102b2e

Merge pull request #883 from SBNSoftware/feature/frameshift_refactor_…

ce18cbd

…v10_11_01_hlay_functions Functionalise

adjust fcl parameters

6a24518

Move constexpr upstream

2d93ca4

Use FrameShiftInfo object in CRT data reconstruction

857c9ed

Add catch for NoShift and allow cutting on ETrig frame

3ca8e1b

add frameshift functionality instead of direclty referencing spec tdc…

d849488

…/ptb

use the pmt calibdb to create the channel mapping

370cd81

vectors are initialized with size,value using parantheses, not braces...

6dcca71

add sbnd services to include pmt calibdb + trigger emulation

761ef7c

Merge pull request #912 from SBNSoftware/feature/frameshift_refactor_…

c66aaa3

…v10_11_01_pmt_crt Add PMT/CRT decoder

update subsystem decoder fcl to include frameshift

a32bc3d

Update LightPropagation module for new timing frmae

57b8b56

clarify fcl param to only count the number of PMT channels per CAEN, …

825c07d

…not all channels per CAEN

update to include Run 2 HLT

c621ba3

Merge branch 'feature/frameshift_refactor_v10_11_01' of https://githu…

f2bc6f9

…b.com/SBNSoftware/sbndcode into feature/frameshift_refactor_v10_11_01

Merge branch 'feature/frameshift_refactor_v10_11_01' of https://githu…

9e19ef9

…b.com/SBNSoftware/sbndcode into feature/frame_shift_refactor_v10_14_02

grab the nanosecond part of timestemp

0ab99f6

Merge branch 'feature/aliciavr_XARAPUCA_offline_decoder_v4.0-extended…

a27480d

…_fragments' into feature/aliciavr-XARAPUCA-offline-decoder-v5.0-frameshift-refactor

feat (frameshift): Add frameshift module to the configuration and acc…

bb1ac48

…ess its products. Additionally, set a frameshift mode boolean t be activated when selecting the frameshift timestamp (this one to be integrated in the workflow)

VCLanNguyen requested a review from PetrilloAtWork May 6, 2026 23:08

Update subtract timestamp implementation

f2489aa

PetrilloAtWork approved these changes May 7, 2026

View reviewed changes

VCLanNguyen and others added 3 commits May 8, 2026 14:58

fix typo

98b16a3

chore (XA-decoder-comments): Add padding to comments

fe533b1

refactor (dataTier-tag): use the same tag in all decoders and framesh…

8e39b47

…ift fcls

Conversation

VCLanNguyen commented Feb 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Link(s) to docdb describing changes (optional)

Relevant PR links (optional)

Checklist

Uh oh!

PetrilloAtWork commented May 7, 2026

Uh oh!

VCLanNguyen commented May 7, 2026

Uh oh!

PetrilloAtWork commented May 7, 2026

Uh oh!

PetrilloAtWork left a comment

Choose a reason for hiding this comment

Uh oh!

VCLanNguyen commented May 8, 2026

Uh oh!

aantonakis commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

aantonakis commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

aantonakis commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

aantonakis commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

FNALbuild commented May 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

VCLanNguyen commented Feb 14, 2026 •

edited

Loading