Repository navigation
bg_triangle.c matches (Fixes Ice Paradise Spotlights) - #221
Merged
Merged
Conversation
JaceCear
changed the title
freshollie
reviewed
Sep 19, 2025
| } | ||
| } | ||
|
|
||
| // NOTE: Has to be below the code for matching... |
Collaborator
There was a problem hiding this comment.
Why?
Ohh I see, yeah it could go in the next file rodata?
Collaborator
There was a problem hiding this comment.
Tbh it probably doesn't make sense that this goes in the next file. Maybe it was allocated in a function but unused
Collaborator
Author
There was a problem hiding this comment.
It not unlikely, but it's weird that the data survived but not the code referencing it.
freshollie
reviewed
Sep 19, 2025
| if (IS_EXTRA_STAGE(gCurrentLevel) && (gFlags & FLAGS_40)) { | ||
| gIntrTable[INTR_INDEX_VCOUNT] = gIntrTableTemplate[INTR_INDEX_VCOUNT]; | ||
| gFlags &= ~FLAGS_EXECUTE_HBLANK_COPY0; | ||
| gFlags &= ~FLAGS_40; |
freshollie
reviewed
Sep 19, 2025
| gFlags |= FLAGS_EXECUTE_HBLANK_CALLBACKS; | ||
| gFlags |= FLAGS_EXECUTE_HBLANK_COPY; | ||
| gHBlankCopySize = 16; | ||
| gHBlankCopySize = sizeof(BgAffineReg); |
Collaborator
There was a problem hiding this comment.
Nice, I wonder how this was working before? Or do the affine regs not change size for the widescreen hack?
Collaborator
Author
There was a problem hiding this comment.
Nah, they don't! ^^
freshollie
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.