z_ui2_json2: replace 70-line skip_node workaround with WA2 (envelope … - #22
Open
alexey-arseniev wants to merge 5 commits into
Open
z_ui2_json2: replace 70-line skip_node workaround with WA2 (envelope …#22alexey-arseniev wants to merge 5 commits into
alexey-arseniev wants to merge 5 commits into
Conversation
alexey-arseniev
force-pushed
the
fix/skip-node-wa2
branch
from
July 3, 2026 16:51
ba662b5 to
6b6bc02
Compare
skip_node( writer ) fails when the reader is positioned on a named node.
Workaround: wrap in a temporary envelope object, call skip_node, then
strip the {"name": prefix and trailing } via string arithmetic.
Replaces the previous 70-line manual tree-walker with 15 lines.
Adds unit test SKIP_NODE_NAMED_MEMBER covering named and unnamed nodes.
alexey-arseniev
force-pushed
the
fix/skip-node-wa2
branch
from
July 3, 2026 17:29
6b6bc02 to
c072a99
Compare
… null Zero-value DECFLOAT16/DECFLOAT34 fields were falling through to the final ELSE branch (serialize as string), which emitted null for initial values. Add explicit WHEN branches matching typekind_decfloat16 and typekind_decfloat34 — zero → '0', non-zero → CONDENSE'd string value. Mirrors the existing FLOAT handling pattern. Adds unit test.
cl_abap_typedescr=>typekind_decfloat16/34 are not available on 7.31
(introduced in 7.40). Replace with local e_typekind-decfloat16/34
constants ('a'/'e') following the same pattern as utclong, int8, enum.
z_ui2_json2 targets 7.57+ so it can keep the class constants directly.
Expand feature 1.2 with an implementation evaluation targeting the next patch level across all three classes (Z_UI2_JSON, /UI2/CL_JSON, Z_UI2_JSON2): API shape, hook points in each parser, reuse of existing skip/consume primitives, and performance analysis for both flag-unused (hot path stays neutral) and flag-used cases. v1 scoped to object-member traversal only. Records the performance-neutrality design rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrap the writer in a temporary envelope object, call skip_node, then strip the {"name": prefix and trailing } via string arithmetic (off = strlen(name) + 4, len - 1).