Skip to content

deploy.sh references the old repo layout and cannot run #97

Description

@arnoweiss

deploy.sh appears to have been carried over unchanged from the previous (internal) repository layout. It references directories, config/manifest templates that no longer exis. As a result it cannot run to completion against the current samples (ams-javalin-shopping, ams-spring-boot-shopping, ams-cap-bookshop).

Broken references

  1. java_dir=java-security-ams (line 3) — no such directory. Current sample dirs are ams-javalin-shopping, ams-spring-boot-shopping, ams-cap-bookshop. (spring-security-ams exists only under legacy-v3-samples/.)
  2. spring_dir=spring-security-ams (line 4) — not at repo root; only exists as legacy-v3-samples/spring-security-ams.
  3. Missing config templatessed'd/read but present nowhere:
    • $folder/ias-config-multi-tenant.json.template (line 69)
    • $folder/ias-config-single-tenant.json.template (line 71)
    • $folder/sms-config.json.template (line 94)
  4. Missing manifest templates — copied by prepare_java_deployment, neither exists:
    • $java_dir/manifest-multi-tenant.yml (line 147)
    • $java_dir/manifest-single-tenant.yml (line 187)
  5. cf push -f "$folder"/manifest.yml (line 102) — no manifest.yml exists in any sample dir, and the "copy template → manifest.yml" chain that would create it is itself broken (see point 4).
  6. The script reads and writes a different set of keys than the ones present in the current vars.yml:
    PROVIDER_SUBACCOUNT_SUBDOMAIN: (lines 149, 166) --> PROVIDER_SUBDOMAIN:
    SUBSCRIBER_SUBACCOUNT_SUBDOMAIN: (lines 150, 182) --> not present

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions