feat(verify): 一条命令验证四个悬浮面板修复都真实生效 - #16
Merged
Merged
Conversation
新增 scripts/demo-fix.mjs:对本仓库 client.js 跑行为测试,再把**同一套测试** 指向上游原版 client.js 跑一遍。第二步是关键——只在本仓库跑通不算证据,必须 证明同一套测试能抓到上游的缺陷,否则测试可能什么都没测。 本机实测: 本仓库: tests 20 | pass 20 | fail 0 ✔ 全绿 上游原版: tests 20 | pass 1 | fail 19 ✔ 有失败(测试有效) 输出里同时列出四个修复与上游 PR 的对应关系,作为本仓库的修复总览。 对应 issue:#2 #3 #4 #5 上游 PR:#65([A]/[C] 同思路,他人提交)、#66([B])、#67([D])
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做什么
新增
scripts/demo-fix.mjs:一条命令验证本仓库的四个悬浮面板修复都真实生效。它分两步:
client.js跑行为测试(单测 + 在 jsdom 里装载真实 bundle 的 e2e);client.js再跑一遍。第二步是关键:只在本仓库跑通不算证据——必须证明同一套测试能抓到上游的缺陷,否则测试可能什么都没测。
本机实测结果
输出末尾会列出四个修复与上游 PR 的对应关系,作为本仓库的修复总览:
[A]tipOwner/clearTip/presentTip[B][C][D]为什么单独开这个 PR
这个仓库的
main本身就是「已修复」状态(相对于上游 1.4.10),所以不存在「把修复合并进 main」的差异。缺的是一个可评审、可追溯的改动来说明这个 fork 到底改了什么、怎么验证——就是这个脚本。关联
Annotation N面板,只闪一下就消失 #2 [Bug] 悬停面板跨「触发元素 → 面板」的 6px 间隙全靠 250ms 赌运气,慢一点就消失 #3 [Bug] 每个面板各持一个宽限定时器却清同一个共享容器:A 的定时器会误杀 B 刚显示的面板 #4 [Bug] 面板监听器无界泄漏:每次渲染都往共享 tipLayer 追加监听器 #5