Skip to content

contracts: sync the CLI contract to InferenceInfra #5602 - #222

Merged
sanchitmonga22 merged 2 commits into
mainfrom
chore/sync-control-plane-contract-5602
Oct 25, 2026
Merged

sanchitmonga22 merged 2 commits into
mainfrom
chore/sync-control-plane-contract-5602

Conversation

@sanchitmonga22

@sanchitmonga22 sanchitmonga22 commented Oct 25, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Contract sync only, produced by python3 contracts/sync_from_inferenceinfra.py --from <InferenceInfra checkout at #5602 head>:

  • contracts/wally-cli-v1.openapi.json: source pin moves to InferenceInfra aa1298ba (branch feat/model-access-review); ApiErrorCode gains access_request_exists, access_request_closed, access_programme_closed, not_staff, invalid_transition; one datacenters description is reworded upstream.
  • src/account/console_contract.rs: regenerated binding (new ApiErrorCode variants, new CONTRACT_SHA256).

No version bump, no versions.toml/Cargo changes, no feature code. Same shape as the equivalent sync commit b7a5b4d on feat/wally-shannon (#219): 2 files, +25/-5.

Why

InferenceInfra #5602's "consumer contract impact" check reports that wally main's pin is stale against the control-plane document (874aaee1b08b -> 4b98a4ca3c3e). Landing this keeps wally main's pin in step so that gate can pass.

Validation

  • python3 contracts/sync_from_inferenceinfra.py --check: console_contract.rs and decisions_contract.rs match the pinned contract; lock OK (aa1298ba).
  • python3 contracts/sync_from_inferenceinfra.py --check --from <#5602 checkout>: lock OK, no drift.
  • cargo fmt --check: clean.
  • cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DWALLY_APPLE_MLX_HOST=OFF -DWALLY_APPLE_CXX_BINARY=ON + cmake --build build + ctest --test-dir build: 6/6 passed (rust tests, help, account, decisions, local harness bins and e2e). Build ran with placeholder console URLs; the Swift MLX host was skipped (needs the SDK tree).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • API responses now provide more specific errors for existing or closed access requests, closed programmes, insufficient staff permissions, and invalid state changes.

sanchitmonga22 and others added 2 commits October 24, 2026 23:37
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Keep wally main's control-plane pin in step with InferenceInfra's
control-plane document so the consumer-impact check on InferenceInfra
#5602 (feat/model-access-review) can pass. Produced by
contracts/sync_from_inferenceinfra.py; the pin moves to aa1298ba (the
#5602 head) and the generated binding gains five ApiErrorCode values:
access_request_exists, access_request_closed, access_programme_closed,
not_staff, invalid_transition. No version bump, no feature code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sanchitmonga22
sanchitmonga22 requested a review from a team as a code owner October 25, 2026 06:43
@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4d9596cf-db0c-4198-b623-493d967284fe
Commits

Reviewing files that changed from the base of the PR and between 1620d8d and 2c24ee9.

Files selected for processing: 2
  • contracts/wally-cli-v1.openapi.json
  • src/account/console_contract.rs

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

Walkthrough

The OpenAPI contract and Rust console contract now include five access-related error codes. The OpenAPI datacenters description and source metadata also changed.

Changes: Access error contract

Layer / File(s) Summary
OpenAPI contract declarations
contracts/wally-cli-v1.openapi.json
The schema adds five error-code values. The datacenters description and source metadata are updated.
Rust error-code mappings
src/account/console_contract.rs
ApiErrorCode adds five variants and maps each to and from its snake-case string. The contract digest is updated.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related PRs

Suggested reviewers: shubhammalhotra28

Merge Risk: Minimal · up to 2c24e

This is a synchronized contract-only change with no identified merge-blocking risk.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main change: syncing the CLI contract with InferenceInfra. It is concise and specific.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files. (1 skipped: 1 unsupported.)

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sanchitmonga22
sanchitmonga22 merged commit 508bd74 into main Oct 25, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants