Skip to content

Unify block deletion and invalid-action errors#98

Merged
jrfaeder merged 1 commit into
RuleWorld:mainfrom
wshlavacek:block-deletion-invalid-action-errors
May 12, 2026
Merged

Unify block deletion and invalid-action errors#98
jrfaeder merged 1 commit into
RuleWorld:mainfrom
wshlavacek:block-deletion-invalid-action-errors

Conversation

@wshlavacek
Copy link
Copy Markdown
Contributor

Summary

  • make missing block-item deletion raise the underlying key/index error instead of printing and continuing
  • let invalid action types fail through the centralized action validation path instead of printing and returning
  • add focused upstream-safe contract tests for the deletion and invalid-action paths

Testing

  • uv run pytest tests/test_block_error_contracts.py -q
  • uv run pytest tests/test_bionetgen.py::test_action_loading -q
  • uvx black --check bionetgen/modelapi/blocks.py bionetgen/network/blocks.py tests/test_block_error_contracts.py

@jrfaeder jrfaeder merged commit a13f8b8 into RuleWorld:main May 12, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants