Clean up block warning paths#97
Merged
Merged
Conversation
wshlavacek
added a commit
to wshlavacek/PyBioNetGen
that referenced
this pull request
May 13, 2026
…edup
The deduplicated `_set_item_attribute` helper rewrote the numeric-coercion
failure warning to "keeping existing {kind}", which regressed the
"keeping existing value"/"keeping existing size" wording that PR RuleWorld#97 (now
in main) standardized on. The merged `tests/test_block_warning_paths.py`
asserts the original wording, so all CI matrix jobs failed after rebase.
Restore "keeping existing {num_field} <existing>" (informative trailer
from PR RuleWorld#97 included) and align the new `test_block_setattr_logging.py`
parameter/compartment fixtures with the canonical messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
uv run pytest tests/test_block_warning_paths.py -quv run pytest tests/test_bng_parsing.py::test_network_parse -quvx black --check bionetgen/modelapi/blocks.py bionetgen/network/blocks.py tests/test_block_warning_paths.py