Added new features: Visual & timing fixes - #5
Open
szoltysek wants to merge 1 commit into
Open
Conversation
Author
|
And I forgot to mention, fixed the npm vulnerabilites and removed some comments, because why not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features: Visual & timing fixes
Fixes a handful of long-standing bugs around animation timing and cover art layout.
Progress bar desync
setTimeout-based reset was brittle by design. Replaced it with a synchronous layout reflow (void border.offsetWidth) - resets are now instant. Also added drift correction: if CSS animation falls more than 1.5s out of sync with the server's reported playback time, it corrects itself automatically. Fixedstart,end, andcurrenttimestamps in theprgrpacket while I was in there -currentwasn't reporting correctly.Options menu
Font stack (or Typography)
-apple-system, BlinkMacSystemFont- San Francisco renders natively on Apple platforms now. Falls back to Inter (Google Fonts) on Linux (not considering Windows a system). Cleaner, sharper, more pleasing for my ADHD eyes.CSS cleanup
.animate.spinningand.thumbnail-border.circlein favor of global layout classes -.circle,.rounded-square. They cascade cleanly down the DOM and are much easier to work with going forward.Known issues & limitations
Cover art spin delay on pause
No playback controls (AirPlay)
Also - my roadmap for this project (I find it really cool):
UI Overhaul - Apple Music / Spotify aesthetic
HomeKit RGB integration
Replace Spotify token flow with data from FOSS Spotify Server - spocon
spoconruns a local server that handles auth transparently, no token juggling. Straightforward swap once I sit down with it.Additional providers