fix(terminal): dedupe raw-terminal warning banner and add warning icon - #452
Open
RonenMars wants to merge 1 commit into
Open
fix(terminal): dedupe raw-terminal warning banner and add warning icon#452RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
Session-level rawFallbackBanner and TerminalView's rawModeNote both fired on low parse confidence, stacking two nearly-identical warnings. Only TerminalView's note remains for that case; the session-level banner now only covers the forceRawTerminal path. Both banners get a warning-triangle icon so they read as distinct from the "Waiting" status badge, which shares the same amber hue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Session-level rawFallbackBanner and TerminalView's rawModeNote both fired on low parse confidence, stacking two nearly-identical warnings on screen.
Only TerminalView's note fires for that case now; the session-level banner covers only the forceRawTerminal path.
Both banners get a warning-triangle icon so they read as visually distinct from the "Waiting" status badge, which shares the same amber hue in every theme.
Test plan
npx eslinton changed files (0 errors, 1 pre-existing unrelated warning)npx tsc --noEmitshows no new errors from this change