fix(terminal): show full session history instead of last 5000 lines - #436
Open
RonenMars wants to merge 1 commit into
Open
fix(terminal): show full session history instead of last 5000 lines#436RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The raw PTY/terminal view already receives the full session transcript from the server (via the WS
terminal_replaymessage or the/api/sessions/{id}/outputHTTP fallback), butpublishLines()truncated it client-side to the last 5000 lines before ever rendering.TerminalOutput's FlashList already supports scrolling through arbitrary line counts with jump-to-top/jump-to-bottom controls, so removing the truncation is enough to let users scroll through the entire loaded conversation.Change
hooks/useTerminalStream.ts:publishLines()no longer slices toterminalMaxLines; it publishes the full parsed scrollback.VirtualTerminal.MAX_ROWS(10,000 rows) remains as a memory ceiling for very long sessions.Test plan
npx eslint hooks/useTerminalStream.tspasses