Skip to content

fix(terminal): show full session history instead of last 5000 lines - #436

Open
RonenMars wants to merge 1 commit into
fix/diff-viewer-full-width-lines-integrationfrom
fix/terminal-load-full-history
Open

fix(terminal): show full session history instead of last 5000 lines#436
RonenMars wants to merge 1 commit into
fix/diff-viewer-full-width-lines-integrationfrom
fix/terminal-load-full-history

Conversation

@RonenMars

Copy link
Copy Markdown
Owner

Summary

The raw PTY/terminal view already receives the full session transcript from the server (via the WS terminal_replay message or the /api/sessions/{id}/output HTTP fallback), but publishLines() truncated it client-side to the last 5000 lines before ever rendering.
TerminalOutput's FlashList already supports scrolling through arbitrary line counts with jump-to-top/jump-to-bottom controls, so removing the truncation is enough to let users scroll through the entire loaded conversation.

Change

  • hooks/useTerminalStream.ts: publishLines() no longer slices to terminalMaxLines; it publishes the full parsed scrollback.
  • VirtualTerminal.MAX_ROWS (10,000 rows) remains as a memory ceiling for very long sessions.

Test plan

  • Open a live session with a long PTY transcript and confirm scrolling up reveals content beyond the previous ~5000-line cutoff
  • Confirm jump-to-top / jump-to-bottom buttons still work
  • npx eslint hooks/useTerminalStream.ts passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant