Skip to content

fix(conversation): stretch diff line rows to full width - #434

Open
RonenMars wants to merge 1 commit into
mainfrom
fix/diff-viewer-full-width-lines
Open

fix(conversation): stretch diff line rows to full width#434
RonenMars wants to merge 1 commit into
mainfrom
fix/diff-viewer-full-width-lines

Conversation

@RonenMars

Copy link
Copy Markdown
Owner

Summary

  • Short diff lines left the added/removed background color hugging the text instead of spanning the horizontal ScrollView's full width.
  • Added a hunksContainer style with minWidth: '100%' on the wrapper inside the horizontal ScrollView in DiffViewer.tsx.

Test plan

  • Open a conversation with a code diff containing short lines and confirm the +/- background now spans full width
  • Confirm long lines still scroll horizontally as before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant