fix(conversation): restore in-chat search button and repair locale drift - #426
Closed
RonenMars wants to merge 1 commit into
Closed
fix(conversation): restore in-chat search button and repair locale drift#426RonenMars wants to merge 1 commit into
RonenMars wants to merge 1 commit into
Conversation
The integration branch has never been run through test.yml, so three failures accumulated unnoticed across ~82 commits. PR #425 was the first thing to trigger CI on it, which surfaced them. Type check and Integration tests both traced to app/conversation/[id].tsx. a1e263c added LivePauseControl to the header actions and, in resolving that conflict, deleted the in-chat search Pressable that ff28c60 had introduced, while leaving the MagnifyingGlass import, the headerButton styles, the searchBarState hook, and the test coverage all in place. The same commit also dropped the makeSearchStyles import while keeping its call site, which is the TS2552 error. Restore both: the import and the search button, verbatim from a1e263c's parent. i18n unused keys flagged three keys with no remaining code reference. b75dfb8 pruned connect.step1 and connect.step2 as dead, but ConnectStep.tsx still renders all three steps as a numbered sequence, so step3 rendered alone after a gap. Restore step1 and step2 in all four locales from their pre-prune text. Drop onboarding.connect.footnote and servers.dialog.removeDismiss, which are genuinely unreferenced. conversation.search.open is left as-is: it labels the restored search button, so it was never dead.
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
integration-merge-354-355-376has never been run throughtest.yml, so three CI failures accumulated unnoticed across ~82 commits.PR #425 was the first thing to trigger CI on that branch, which is how they surfaced.
None of them were caused by #425; this PR fixes them so that branch can go green.
Type check + Integration tests
Both traced to a single lost code block in
app/conversation/[id].tsx.a1e263c1addedLivePauseControlto the header actions and, in resolving that conflict, deleted the in-chat searchPressablethatff28c605had introduced.Everything around it survived: the
MagnifyingGlassimport, theheaderButton/headerButtonActivestyles, thesearchBarStatehook, thesearch.openlocale key, and the full test coverage.The same commit dropped the
makeSearchStylesimport while leaving its call site at line 67, which is theTS2552: Cannot find name 'makeSearchStyles'error.Restored both, verbatim from
a1e263c1^.This is a real user-facing regression, not just a test fix — in-chat search has had no entry point on the conversation detail screen since that commit.
i18n unused keys
Three keys had no remaining code reference.
b75dfb87prunedconnect.step1andconnect.step2as dead, butConnectStep.tsx:196-198still renders all three steps as a numbered sequence, so users saw a gap and then "3. …" alone.Restored
step1andstep2in all four locales using their pre-prune text from history, so no translations were invented.Dropped
onboarding.connect.footnoteandservers.dialog.removeDismiss, which are genuinely unreferenced.conversation.search.openis deliberately left untouched: it is the restored button'saccessibilityLabel, so it was never dead.Test plan
Notes
Worth considering why this went unseen:
test.ymltriggers onpull_requestand on pushes tomain/chore/bump-**, so a long-lived integration branch accumulating direct commits never gets a CI run.Adding it to the
pushbranch list would catch this class of drift at the commit that causes it rather than 82 commits later.