Skip to content

fix(conversation): restore in-chat search button and repair locale drift - #426

Closed
RonenMars wants to merge 1 commit into
integration-merge-354-355-376from
fix/integration-branch-ci-failures
Closed

fix(conversation): restore in-chat search button and repair locale drift#426
RonenMars wants to merge 1 commit into
integration-merge-354-355-376from
fix/integration-branch-ci-failures

Conversation

@RonenMars

Copy link
Copy Markdown
Owner

Summary

integration-merge-354-355-376 has never been run through test.yml, so three CI failures accumulated unnoticed across ~82 commits.
PR #425 was the first thing to trigger CI on that branch, which is how they surfaced.
None of them were caused by #425; this PR fixes them so that branch can go green.

Type check + Integration tests

Both traced to a single lost code block in app/conversation/[id].tsx.

a1e263c1 added LivePauseControl to the header actions and, in resolving that conflict, deleted the in-chat search Pressable that ff28c605 had introduced.
Everything around it survived: the MagnifyingGlass import, the headerButton / headerButtonActive styles, the searchBarState hook, the search.open locale key, and the full test coverage.
The same commit dropped the makeSearchStyles import while leaving its call site at line 67, which is the TS2552: Cannot find name 'makeSearchStyles' error.

Restored both, verbatim from a1e263c1^.
This is a real user-facing regression, not just a test fix — in-chat search has had no entry point on the conversation detail screen since that commit.

i18n unused keys

Three keys had no remaining code reference.

b75dfb87 pruned connect.step1 and connect.step2 as dead, but ConnectStep.tsx:196-198 still renders all three steps as a numbered sequence, so users saw a gap and then "3. …" alone.
Restored step1 and step2 in all four locales using their pre-prune text from history, so no translations were invented.

Dropped onboarding.connect.footnote and servers.dialog.removeDismiss, which are genuinely unreferenced.

conversation.search.open is deliberately left untouched: it is the restored button's accessibilityLabel, so it was never dead.

Test plan

  • Type check: clean (was 3 errors)
  • Integration tests: 39/39 suites, 239/239 tests pass (was 4 suites / 34 tests failing)
  • i18n: 3/3 suites, 55 passed (was 1 suite / 3 tests failing)
  • Unit tests: 95/95 suites, 897 tests pass
  • ESLint clean on the modified file
  • Manually confirm the search icon appears in the conversation header and toggles the search bar

Notes

Worth considering why this went unseen: test.yml triggers on pull_request and on pushes to main / chore/bump-**, so a long-lived integration branch accumulating direct commits never gets a CI run.
Adding it to the push branch list would catch this class of drift at the commit that causes it rather than 82 commits later.

The integration branch has never been run through test.yml, so three failures accumulated unnoticed across ~82 commits.
PR #425 was the first thing to trigger CI on it, which surfaced them.

Type check and Integration tests both traced to app/conversation/[id].tsx.
a1e263c added LivePauseControl to the header actions and, in resolving that conflict, deleted the in-chat search Pressable that ff28c60 had introduced, while leaving the MagnifyingGlass import, the headerButton styles, the searchBarState hook, and the test coverage all in place.
The same commit also dropped the makeSearchStyles import while keeping its call site, which is the TS2552 error.
Restore both: the import and the search button, verbatim from a1e263c's parent.

i18n unused keys flagged three keys with no remaining code reference.
b75dfb8 pruned connect.step1 and connect.step2 as dead, but ConnectStep.tsx still renders all three steps as a numbered sequence, so step3 rendered alone after a gap.
Restore step1 and step2 in all four locales from their pre-prune text.
Drop onboarding.connect.footnote and servers.dialog.removeDismiss, which are genuinely unreferenced.

conversation.search.open is left as-is: it labels the restored search button, so it was never dead.
@RonenMars
RonenMars deleted the branch integration-merge-354-355-376 July 26, 2026 08:09
@RonenMars RonenMars closed this Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant