Repository navigation
fix(ci): pin the k8s E2E cluster name (#1040) - #1042
RonaldHensbergen wants to merge 1 commit into
Conversation
The CI checkout is a detached HEAD, so the branch-derived default in k3d-env.sh named the cluster "cds-head". Pin CDS_CLUSTER to "cds-k8s-e2e-ci" in the job env for attributable logs and diagnostics, and pin the invariant in test_k8s_e2e_workflow.py. Generated by Mistral Vibe. Co-Authored-By: Mistral Vibe <vibe@mistral.ai>
|
RonaldHensbergen
left a comment
RonaldHensbergen
left a comment
There was a problem hiding this comment.
Self-review (contributor == reviewer), all angles checked.
Blocking: none.
Major: none.
Minor: none.
Verified beyond the diff itself:
- Runtime proof, not just green rendering: the E2E job log on this very commit shows
creating cluster cds-k8s-e2e-cianddeleting cluster cds-k8s-e2e-ci— the fix works at runtime, not only in YAML. - All 14 checks green on b652c8b, including the k3d E2E job (4m35s) and SonarCloud.
- Full suite locally: 1972 passed / 24 skipped; ruff and yamllint clean.
- CHANGELOG [Unreleased] Fixed entry present; no E-/W-codes added, so no README troubleshooting or code-collision impact; minimal 3-file diff.
Conclusion: no loose ends or gaps remain for this PR; in my judgment it is merge-ready.
| env: | ||
| # actions/checkout leaves the runner at a detached HEAD, so the | ||
| # branch-derived default in k3d-env.sh would name the cluster "cds-head". | ||
| CDS_CLUSTER: cds-k8s-e2e-ci |
There was a problem hiding this comment.
Verified at runtime: the E2E job log on this commit shows creating cluster cds-k8s-e2e-ci and deleting cluster cds-k8s-e2e-ci.
| self.assertEqual(steps["Delete cluster"]["if"], "always()") | ||
| self.assertEqual(steps["Delete cluster"]["run"], "make k3d-down") | ||
|
|
||
| def test_job_pins_a_stable_cluster_name(self) -> None: |
There was a problem hiding this comment.
Good: the invariant is pinned so the cluster name cannot silently regress to a derived name.
|
|
||
| ### Fixed | ||
|
|
||
| - The `Kubernetes E2E` workflow now pins its k3d cluster name |
There was a problem hiding this comment.
Placed under [Unreleased] Fixed with the #1040 reference, matching the repo convention.
Closes #1040.
Follow-up from the #1027 review: the CI checkout is a detached HEAD, so
k3d-env.sh's branch-derived default named the clustercds-head. This pinsCDS_CLUSTER: cds-k8s-e2e-ciin the job env (with a comment explaining why), pins the invariant intests/test_k8s_e2e_workflow.py, and adds a CHANGELOG entry.Verified locally: full suite 1972 passed / 24 skipped, ruff and yamllint clean. The workflow itself changes, so the k8s E2E job runs on this PR and will show the new cluster name in its
make k3d-downstep.