Skip to content

⚡ Bolt: Fix N+1 query in periodic grievance evaluation #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
RohanExploit wants to merge 2 commits into from
Closed

⚡ Bolt: Fix N+1 query in periodic grievance evaluation #918

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ed06df
⚡ Bolt: Fix N+1 query in periodic grievance evaluation
RohanExploit Jul 19, 2026
d5b1b34
⚡ Bolt: Fix deployment by resolving main.py indentation syntax error
RohanExploit Jul 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/bolt.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,7 @@
## 2025-07-15 - Fast Bounding Box Pre-filter
**Learning:** Calculating great circle distance (Haversine) for every issue against a target location is computationally expensive (O(N) with heavy math ops like sin, cos, atan2). In high-traffic aggregations, this can become a bottleneck.
**Action:** Use a fast bounding box pre-filter (`get_bounding_box` with a 5% epsilon) to quickly discard issues that are definitely outside the search radius before running the expensive exact haversine distance calculation.

## 2026-07-19 - [Resolve N+1 Queries in Periodic Grievance Evaluation]
**Learning:** During periodic grievance escalation evaluations, iterating over a list of grievances and accessing the related `jurisdiction` triggers N+1 queries. Specifically, in `EscalationEngine._get_grievances_for_evaluation`, `grievance.jurisdiction.level` is frequently accessed to determine escalation paths.
**Action:** When querying models that will be evaluated sequentially where relationships are accessed, use `joinedload(Model.relation)` to fetch relations eagerly in a single database query.
7 changes: 5 additions & 2 deletions backend/escalation_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

import datetime
from typing import List, Dict, Any, Optional
from sqlalchemy.orm import Session
from sqlalchemy.orm import Session, joinedload
from sqlalchemy import and_, or_
from backend.models import Grievance, Jurisdiction, EscalationAudit, GrievanceStatus, JurisdictionLevel, EscalationReason, SeverityLevel
from backend.database import SessionLocal
Expand Down Expand Up @@ -150,7 +150,10 @@ def _get_grievances_for_evaluation(self, db: Session) -> List[Grievance]:
now = datetime.datetime.now(datetime.timezone.utc)

# Get grievances that are active and past SLA deadline
return db.query(Grievance).filter(
# Bolt Optimization: Added joinedload(Grievance.jurisdiction) to prevent N+1 queries during evaluation
return db.query(Grievance).options(
joinedload(Grievance.jurisdiction)
).filter(
and_(
Grievance.status.in_([GrievanceStatus.OPEN, GrievanceStatus.IN_PROGRESS, GrievanceStatus.ESCALATED]),
Grievance.sla_deadline < now
Expand Down
28 changes: 16 additions & 12 deletions backend/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import json
import os
import io
import sys

# Add the project root to sys.path so we can import 'backend' modules
sys.path.append(os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
Expand Down Expand Up @@ -239,6 +240,9 @@ def save_file():

await asyncio.to_thread(save_file)

except Exception as e:
logger.error(f"Failed to process image: {e}")

@cubic-dev-ai cubic-dev-ai Bot Jul 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1: Image-upload failures now raise another NameError in the exception handler because logger is undefined; currently every request reaches it because save_file() uses undefined image_path (and asyncio is also undefined). Define/use the correct path and imports, then return an HTTP error rather than continuing after a failed upload.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At backend/main.py, line 244:

<comment>Image-upload failures now raise another `NameError` in the exception handler because `logger` is undefined; currently every request reaches it because `save_file()` uses undefined `image_path` (and `asyncio` is also undefined). Define/use the correct path and imports, then return an HTTP error rather than continuing after a failed upload.</comment>

<file context>
@@ -239,6 +240,9 @@ def save_file():
         await asyncio.to_thread(save_file)
 
+    except Exception as e:
+        logger.error(f"Failed to process image: {e}")
+
     # Offload blocking DB operations to a thread
</file context>


# Offload blocking DB operations to a thread
def save_to_db():
new_issue = Issue(
Expand All @@ -254,19 +258,19 @@ def save_to_db():

new_issue = await asyncio.to_thread(save_to_db)

# Generate Action Plan (AI)
action_plan = await generate_action_plan(description, category, file_location)
# Generate Action Plan (AI)
action_plan = await generate_action_plan(description, category, file_location)

db_issue = Issue(
description=description,
category=category,
image_path=file_location,
source=source,
user_email=user_email
)
db.add(db_issue)
db.commit()
db.refresh(db_issue)
db_issue = Issue(
description=description,
category=category,
image_path=file_location,
source=source,
user_email=user_email
)
db.add(db_issue)
db.commit()
db.refresh(db_issue)

return {
"id": new_issue.id,
Expand Down
Loading