chore: remove unused replaceLog/silence from log.ts - #392
Open
ayushi-wq wants to merge 1 commit into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the unused
replaceLogandsilencefunctions fromlib/log.ts. Neither has any caller anywhere in the SDK source — the SDK already uses per-instance logger injection (viaApiandDriverconstructor options) as its actual mechanism for controlling logging, so the global mutableloggerswap was dead code.loggeritself is left in place, since it's still used internally byInternalLog.Verified no callers of
replaceLog/silenceanywhere inlib/(only their own definitions), and confirmedindex.tsdoes not export them. Typecheck, lint, and full test suite (302/302) all pass with no new issues.Closes #380