fix: stop request() refusing pre-login REST calls - #387
Open
diegolmello wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Api.requestgated every call onauth && !this.loggedIn()and threwrequires a loginlocally, so noEndpointcalled before aLoginever reached theREST client.authnever controlled the auth headers —setLoginattaches those from theCurrent login— so the guard was a client-side pre-flight duplicating a decision only the server can make, and could only produce false negatives.Removes the guard and the
authparameter entirely, fromrequest, thepost/get/put/delwrappers,IAPIRequest, and all 15 call sites (includinginfo(), which passedthis.loggedIn()).loggedIn()stays public and unchanged.Closes #385
Steps to reproduce
Apiwith noLogin, socurrentLoginisnull.poston a pre-loginEndpoint, e.g.users.forgotPassword.requires a loginand theREST clientis never called. After: the request goes out.Tests
sends a request with no login— withcurrentLogin === null,post('users.forgotPassword', …)reaches theREST clientwith theEndpointand payload intact.sends info() authenticated once logged in— existing case, still confirms auth headers are attached with aCurrent loginset.