fix: allow fast inference without control signals - #64
Open
primorLee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate_fast.pyexposes--action_pathas optional, butWanI2VFast.generate()unconditionally splitc2ws_plucker_embafter the camera-preparation block. When no control path was provided, that local variable was never defined and fast inference failed before the first DiT call.This change keeps camera chunks optional and passes
dit_cond_dict=Nonefor uncontrolled generation, which is already supported byWanModelFast.forward(). The controlled path retains the same tensor chunking and condition dictionary.Validation
python -m py_compile wan/image2video_fast.pyWanI2VFast.generate()control flow with CPU fake model/T5/VAE components:UnboundLocalError(3, 9, 32, 64)