Repository navigation
fix: receipt_id の品目化を支出に限定 - #69
Merged
Merged
Conversation
収入60件だけを安全に復元するコマンドを追加し、支出の計画値を維持する。更新直後は全列を再取得し、receipt_id 以外の変化を検出する。 ADR-0030をADR-0035で置換し、今後は支出の品名をnameへ移行するときだけreceipt_idを採番する。 Assisted-By: OpenAI Codex 🤖
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
11 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue #37 で収入 60 件にも receipt_id を後付けしたが、品目入力と receipt_id の効果を確認できているのは支出だけだった。支出 1,080 件の計画値を維持し、収入だけを安全に receipt_id = 0 へ戻せるようにする。
変更
検証
マージ後
main で --rollback-income を実行して収入 60 件だけを戻し、同期後の本番 D1 で独自採番域が payment 1,080 件だけであることを確認する。実データ補正が完了するまで Issue #37 は閉じない。
Refs #37
🤖 Generated with Codex